New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run2-alca155 Source code reformatting with clang-format in Calibration/HcalAlCaRecoProducers #26450
Conversation
The code-checks are being triggered in jenkins. |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26450/9257
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26450/9261
|
A new Pull Request was created by @bsunanda for master. It involves the following packages: Calibration/HcalAlCaRecoProducers @cmsbuild, @franzoni, @christopheralanwest, @pohsun, @tocheng can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild Please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
@bsunanda sorry, which clang warning are you referring to? This looks like a source code reformatting with clang-format, I do not see warnings from the clang compiler for this packages in https://cmssdt.cern.ch/SDT/cgi-bin/showBuildLogs.py/slc7_amd64_gcc700/www/mon/10.6.CLANG-mon-23/CMSSW_10_6_CLANG_X_2019-04-15-2300 |
@fabiocos You are right - let me correct title |
+1 |
PR description:
Source code reformatting with clang-format in the package Calibration/HcalAlCaRecoProducers
PR validation:
Successfully runs the runTheMatrix test workflows
if this PR is a backport please specify the original PR:
No back porting needed