New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[muon] updated multiIso working points #26459
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26459/9277
|
A new Pull Request was created by @drkovalskyi for master. It involves the following packages: PhysicsTools/PatAlgos @perrotta, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@drkovalskyi please add a link to the supporting documentation of the new working point in the PR description. |
|
||
muon.setSelector(reco::Muon::MultiIsoLoose, miniIsoValue<0.40 && (muon.jetPtRatio() > 0.80 || muon.jetPtRel() > 7.2) ); | ||
muon.setSelector(reco::Muon::MultiIsoMedium, miniIsoValue<0.16 && (muon.jetPtRatio() > 0.76 || muon.jetPtRel() > 7.2) ); | ||
muon.setSelector(reco::Muon::MultiIsoMedium, miniIsoValue<0.11 && (muon.jetPtRatio() > 0.74 || muon.jetPtRel() > 6.8) ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found these cuts in https://twiki.cern.ch/twiki/bin/view/CMS/SUSLeptonSF#ID_IP_ISO
these are quoted as Medium2017data_V32JEC
.
This looks like WPs change depending on the version of miniAOD processing.
Is this setting approved/OK for (re)miniAOD of 2016 80X RECO/AOD or for 2018 102X RECO/AOD?
What about the 10_6_X itself (legacy rereco)?
@gzevi please advise or tag someone who can clarify.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We won't track JEC changes, i.e. whatever JET pt is used during processing it will be the Pt used in the selector. Muon POG will only provide scale factors for pre-computed selectors. It was discussed with @gzevi and it was concluded that it's still useful for SUSY group. If not, we will drop both working points.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, it sounds like we are not yet in the phase space of a broken clock.
+1
|
+1 @santocch please have a look, this code is relevant for miniAOD processing but for analysis use in general |
merge |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
An update for supported multiIso working points based on input from SUSY group (@gzevi ). Dropped unsupported working points.