New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add trigger bit to emulated GlobalExtBlk to indicate event was not selected … #26461
Add trigger bit to emulated GlobalExtBlk to indicate event was not selected … #26461
Conversation
…due to prefiring of the trigger
The code-checks are being triggered in jenkins. |
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26461/9282
|
The tests are being triggered in jenkins. |
A new Pull Request was created by @apana (Leonard Apanasvich) for master. It involves the following packages: Configuration/StandardSequences @cmsbuild, @rekovic, @franzoni, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Comparison job queued. |
+1 |
Comparison is ready Comparison Summary:
|
@apana do I understand correctly that the decision can be accessed calling: I am not sure I fully understand the reason of the code below.
|
|
||
makeTriggerRulePrefireVetoBit_=false; | ||
|
||
m_triggerRulePrefireVetoBit=255; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@apana @rekovic this magic value looks related to https://github.com/cms-sw/cmssw/blob/master/DataFormats/L1TGlobal/interface/GlobalExtBlk.h#L47 and now everything looks consistent. But why having the two as independent, and using a LogWarning that risks to go unnoticed? If this has to be the last bit of the array just use that position no? Otherwise I would escalate the severity to LogError at least (although still it does not seem the best solution to me...)
Looking at the GlobalExtBlk constructor here:
one would need to have at least a method to get the size of the m_extDecision vector:
otherwise it's impossible to reverse-engineer the logic you use to set the 255-or-max-minus-1 bit of that vector. |
+operations the previous circular dependency of tcdsDigis and rawDataCollector looks to have been solved,, and the TauEmbedding previously failing unit test now works smoothly |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
@peruzzim @apana |
…due to prefiring of the trigger
PR description:
PR validation:
if this PR is a backport please specify the original PR:
Before submitting your pull requests, make sure you followed this checklist: