Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trigger bit to emulated GlobalExtBlk to indicate event was not selected … #26461

Conversation

apana
Copy link
Contributor

@apana apana commented Apr 15, 2019

…due to prefiring of the trigger

PR description:

PR validation:

if this PR is a backport please specify the original PR:

Before submitting your pull requests, make sure you followed this checklist:

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@rekovic
Copy link
Contributor

rekovic commented Apr 15, 2019

please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26461/9282

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 15, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34210/console Started: 2019/04/15 19:34

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @apana (Leonard Apanasvich) for master.

It involves the following packages:

Configuration/StandardSequences
L1Trigger/L1TGlobal

@cmsbuild, @rekovic, @franzoni, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@rekovic
Copy link
Contributor

rekovic commented Apr 15, 2019

+1

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26461/34210/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3142783
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3142585
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@peruzzim
Copy link
Contributor

@apana do I understand correctly that the decision can be accessed calling:
GlobalExtBlk::getExternalDecision(255)
on this product that is in miniAOD:
BXVector<GlobalExtBlk> "gtStage2Digis" "" "RECO"

I am not sure I fully understand the reason of the code below.
Is there a way to read from the event what GlobalExtBlk:: maxExternalConditions was in the release used to run the trigger? (imagine I want to read a 10_2_X MiniAOD from a later release, where this value has changed)

if (m_triggerRulePrefireVetoBit > GlobalExtBlk::maxExternalConditions-1){


makeTriggerRulePrefireVetoBit_=false;

m_triggerRulePrefireVetoBit=255;
Copy link
Contributor

@fabiocos fabiocos Apr 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@apana @rekovic this magic value looks related to https://github.com/cms-sw/cmssw/blob/master/DataFormats/L1TGlobal/interface/GlobalExtBlk.h#L47 and now everything looks consistent. But why having the two as independent, and using a LogWarning that risks to go unnoticed? If this has to be the last bit of the array just use that position no? Otherwise I would escalate the severity to LogError at least (although still it does not seem the best solution to me...)

@peruzzim
Copy link
Contributor

Looking at the GlobalExtBlk constructor here:

m_extDecision.assign(maxExternalConditions,false);

one would need to have at least a method to get the size of the m_extDecision vector:
std::vector<bool> m_extDecision;

otherwise it's impossible to reverse-engineer the logic you use to set the 255-or-max-minus-1 bit of that vector.

@fabiocos
Copy link
Contributor

+operations

the previous circular dependency of tcdsDigis and rawDataCollector looks to have been solved,, and the TauEmbedding previously failing unit test now works smoothly

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit e25777d into cms-sw:master Apr 18, 2019
@rekovic
Copy link
Contributor

rekovic commented Apr 18, 2019

@peruzzim
These comments are valid: avoiding setting the size by hand here and having a public accessor which is transparent to the position of this bit.

@apana
Not to introduce delay in integration of the PR now, after this PR is merged (soon), we need to follow up with another PR which provide the above functionality.

@apana
Copy link
Contributor Author

apana commented Apr 19, 2019

Dear @peruzzim and @rekovic,

I agree this could have been coded better. I will try to put in the follow up PR asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants