Cleanup ECAL topology construction

[makortel]

PR description:

This PR came out as a preparatory cleanup for migrating Geometry/CaloEventSetup/CaloTopologyBuilder to EventSetup-consumes and ESGetToken:

• RecoEcal/EgammaClusterAlgos/PreshowerPhiClusterAlgo and RecoEcal/EgammaClusterProducers/PreshowerPhiClusterProducer do not use CaloSubdetectorTopology so its use is removed from those classes
• Construct EcalBarrelTopology and EcalEndcapTopology directly from CaloGeometry instead of edm::ESHandle<CaloGeometry>, and remove the CaloGeometry parameter from EcalPreshowerTopology constructor as it was not used
• CaloTopology takes and stores the subdetector topologies as std::unique_ptrs.

I was surprised how widely spread it is to create the ECAL topology objects on the fly (for each event) instead of asking them from EventSetup.

PR validation:

Tested in CMSSW_10_6_X_2019-04-15-1100 that the code compiles and limited matrix runs. No changes expected.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26466/9298

• This PR adds an extra 88KB to repository

[cmsbuild]

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

Calibration/EcalCalibAlgos
Geometry/CaloEventSetup
Geometry/CaloTopology
HLTrigger/special
RecoEcal/EgammaClusterAlgos
RecoEcal/EgammaClusterProducers
RecoEcal/EgammaCoreTools
RecoEgamma/EgammaHLTProducers
RecoParticleFlow/PFClusterProducer

@perrotta, @cmsbuild, @civanch, @Dr15Jones, @cvuosalo, @tlampen, @christopheralanwest, @ianna, @mdhildreth, @Martin-Grunewald, @franzoni, @tocheng, @slava77, @fwyzard, @pohsun can you please review it and eventually sign? Thanks.
@mmarionncern, @Sam-Harper, @battibass, @felicepantaleo, @jainshilpi, @cbernet, @folguera, @rovere, @lgray, @Martin-Grunewald, @calderona, @HuguesBrun, @seemasharmafnal, @hatakeyamak, @tocheng, @mmusich, @argiro, @varuns23, @bachtis this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[makortel]

@cmsbuild, please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34222/console Started: 2019/04/16 17:37

[cmsbuild]

+1
Tested at: 1b364fd
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26466/34222/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26466/34222/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3142783
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3142585
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 133 log files, 14 edm output root files, 32 DQM output files

[slava77]

+1

for #26466 1b364fd

• code changes are in line with the PR description; technical
• jenkins tests pass and comparisons with the baseline show no differences

[pohsun]

+1

[makortel]

@slava77 Is my observation

I was surprised how widely spread it is to create the ECAL topology objects on the fly (for each event) instead of asking them from EventSetup.

worth to be followed up (starting with an issue)?

[cvuosalo]

+1

[slava77]

+1

@cvuosalo or @makortel would you like to make one?
It seems like use cases are not even close to be limited to reco.

[makortel]

I created an issue #26498.

[fabiocos]

@Martin-Grunewald this PR is waiting for hlt signature. Do you see any issue with it?

[Martin-Grunewald]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1