Era based effective area to be used in Muon selectors

[bmahakud]

PR description:

• This PR is made after closing the PR Adding Era dependent effective area for miniIsolation calculation in muon selectors #26292
• Adding Era dependent effective area for mini isolation calculation
• The ticket that concerns this is : https://its.cern.ch/jira/browse/CMSMUONS-206
• The effective areas that are used to calculate the mini Isolation changes with Era
• All comments from the previous PR are addressed here.
• @perrotta @slava77 @folguera @drkovalskyi
  Please look at the Era implementation. This is important as newly created tags run2_muon_2016, run2_muon_2017 and run2_muon_2017 will be used in other future muon POG related PRs.
  --

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26489/9344

• This PR adds an extra 44KB to repository

[cmsbuild]

A new Pull Request was created by @bmahakud (Bibhuprasad Mahakud) for master.

It involves the following packages:

Configuration/Eras
PhysicsTools/PatAlgos
PhysicsTools/PatUtils

@perrotta, @cmsbuild, @franzoni, @slava77, @santocch, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@TaiSakuma, @gouskos, @rappoccio, @Martin-Grunewald, @ahinzmann, @peruzzim, @seemasharmafnal, @mmarionncern, @makortel, @smoortga, @acaudron, @jdolen, @drkovalskyi, @ferencek, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @clelange, @HeinerTholen, @JyothsnaKomaragiri, @mverzett, @gpetruc, @mariadalfonso, @pvmulder this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26489/9345

• This PR adds an extra 48KB to repository

[cmsbuild]

Pull request #26489 was updated. @perrotta, @cmsbuild, @franzoni, @slava77, @santocch, @fabiocos, @davidlange6 can you please check and sign again.

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34263/console Started: 2019/04/17 21:42

[cmsbuild]

+1
Tested at: 07e6175
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26489/34263/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26489/34263/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3142783
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3142585
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 133 log files, 14 edm output root files, 32 DQM output files

[slava77]

there are no changes in the selector values.
It seems like something is not working.

[bmahakud]

@slava77 I will try check soon to know the expected changes.

[slava77]

@bmahakud
please provide a link to slides which describe the new EA documentation.
Thank you.

[slava77]

+1

for #26489 07e6175

• code changes are in line with the PR description and the follow up review
• jenkins tests pass and comparisons with the baseline show no differences
  • local test with wf 136.8311 1K events (x10 of what's in jenkins) showed some differences. In fact there is a diff even in the cms-bot output, but it requires a manual comparison to see a change, which is not visible at the histogram bin content level.

[santocch]

+1

[bmahakud]

@slava77

• I did a event by event comparison of print report of miniIsolation while running runTheMatrix -l 10824.0 (TTbar_13TeV_TuneCUETP8M1) and found nothing suspicious.
• From code point of view everything seems to work fine.
• I did print 1.) Effective area, 2.) miniIsolation value, 3.) correction to isolation (depends on effective area) and 4.) muon Eta at this point https://github.com/bmahakud/cmssw/blob/EraBasedEffectiveAreaFinalPR/PhysicsTools/PatUtils/src/MiniIsolation.cc#L72
• The print report (2018 vs 2016)shows infact code works fine but changes in miniIsolation values look very small, that could be the reason why you saw negligible differences
• Print report available at : https://github.com/bmahakud/bibhuRepo/blob/master/PrintReportWith2016EffectiveArea.txt
  https://github.com/bmahakud/bibhuRepo/blob/master/PrintReportWith2018EffectiveArea.txt

[bmahakud]

@bmahakud
please provide a link to slides which describe the new EA documentation.
Thank you.

@folguera Can you help in getting links of slides as Slava has asked.

[slava77]

@fabiocos @kpedro88
another reco/miniAOD PR relies on this one.
please check this PR and merge or propose modifications at your earliest.
Thank you.

[kpedro88]

+1

[kpedro88]

merge

[fabiocos]

+operations

the addition of eras is coherent with the purpose of the PR

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.