HcalCalibDetId fix

[abdoulline]

PR description:

After expanded tests of a full new HCAL emap, it was found that some newly added HBX/HEX channels' attributes aren't packed properly in CalibDetId in 10_6_0_pre4
(with recent PR #26432)

PR validation:

(1) runTheMatrix is OK;
(2) re-dumping of ASCII emap (packing/unpacking of pairs of HcalElectronicsId & HcalCalibDetId) show no issues now.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26505/9367

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @abdoulline (Salavat Abdullin) for master.

It involves the following packages:

DataFormats/HcalDetId

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @mariadalfonso, @rovere this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[abdoulline]

@civanch Vladimir, could you type
"please test" ?

[civanch]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34331/console Started: 2019/04/24 23:05

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

+1
Tested at: 7714658
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26505/34331/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26505/34331/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3211964
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3211759
• DQMHistoTests: Total skipped: 204
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[kpedro88]

+1