Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce relval worflow for beam-halo in 2018 and post-LS2 detector configuration #26510

Merged
merged 3 commits into from May 6, 2019

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Apr 23, 2019

PR description:

As there is renewed interest within the Tracker DPG about using Beam Halo tracks for tracker alignment purposes during Run 3, and we currently have only a configuration from run1 in the matrix, we would like to propose an updated version using the 2018 detector (which at least features the phase-1 pixel detector) and the post-LS2 (2019 at the moment).
I profit of this PR to add also a workflow for post-LS2 cosmics production.

Notice, though, that at the moment the GT used for the post-LS2 workflows are still the collisions one, since the post-LS2 cosmics GT is missing (see request at: https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/4124.html )

As the cosmics digitization for Run3 is not working at the moment due to missing castor SimHits I also fix that by adding a modifier for the comics workflow (apparently left-over in commit 0b1663f)

PR validation:

within CMSSW_10_6_X_2019-04-23-1100 the command:

runTheMatrix.py -l 7.23
runTheMatrix.py -l 8.1
runTheMatrix.py -l 8.2

run to completion, producing 10 events in RECO data-tier.

if this PR is a backport please specify the original PR:

This is not a backport

@mtosi @adewit @connorpa

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26510/9373

  • This PR adds an extra 52KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

Configuration/PyReleaseValidation

@pgunnell, @zhenhu, @prebello, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@prebello
Copy link
Contributor

please test workflow 8.20

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 24, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34321/console Started: 2019/04/24 15:20

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26510/34321/summary.html

There are some workflows for which there are errors in the baseline:
1001.0 step 2
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-26510/8.2_BeamHalo_UP18+BeamHalo_UP18+DIGICOS_UP18+RECOCOS_UP18+ALCABH_UP18+HARVESTCOS_UP18

Comparison Summary:

  • You potentially added 525 lines to the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3211870
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3211665
  • DQMHistoTests: Total skipped: 204
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 130 log files, 14 edm output root files, 32 DQM output files

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26510/34385/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3211964
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3211759
  • DQMHistoTests: Total skipped: 204
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@civanch
Copy link
Contributor

civanch commented Apr 28, 2019

+1

@kpedro88
Copy link
Contributor

+upgrade

@prebello
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@prebello
Copy link
Contributor

@kpedro88 I have seen now that it has still string 19 instead of 21. It should be changed to match the new policy for Run3 relvals.

@kpedro88
Copy link
Contributor

@prebello in CMSSW we develop against master. The change from 19 to 21 has not entered master yet. If it enters before this PR, then this PR will be rebased accordingly. If this PR enters first, the other PR will be rebased to propagate the change.

@fabiocos
Copy link
Contributor

fabiocos commented May 6, 2019

@mmusich @kpedro88 as agreed with @boudoul at this point I would move forward with this PR and adjust the other one

@fabiocos
Copy link
Contributor

fabiocos commented May 6, 2019

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants