Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate L1 step to Tasks #26549

Merged
merged 2 commits into from May 2, 2019
Merged

Migrate L1 step to Tasks #26549

merged 2 commits into from May 2, 2019

Conversation

makortel
Copy link
Contributor

PR description:

This PR migrates the L1 (simulation) step to use Tasks in the configuration. This change should increase the available concurrency in the jobs running the L1.

PR validation:

Limited matrix runs.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26549/9447

  • This PR adds an extra 40KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

Configuration/StandardSequences
HLTrigger/Configuration
L1Trigger/Configuration
L1Trigger/L1TCalorimeter
L1Trigger/L1TGlobal
L1Trigger/L1THGCal
L1Trigger/L1THGCalUtilities
L1Trigger/L1TMuon
L1Trigger/ME0Trigger

@cmsbuild, @kpedro88, @Martin-Grunewald, @rekovic, @franzoni, @fwyzard, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@amarini, @geoff-smith, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @jbsauvan, @thomreis, @dildick, @lgray, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor Author

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 26, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34367/console Started: 2019/04/26 18:08

@cmsbuild
Copy link
Contributor

-1

Tested at: cf979a1

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26549/34367/summary.html

I found follow errors while testing this PR

Failed tests: AddOn

  • AddOn:

I found errors in the following addon tests:

cmsRun /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_6_X_2019-04-25-2300/src/HLTrigger/Configuration/test/OnLine_HLT_HIon.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Fri Apr 26 20:31:22 2019-date Fri Apr 26 20:17:12 2019 s - exit: 17920
cmsDriver.py RelVal -s HLT:HIon,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_HIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018_pp_on_AA --processName=HLTRECO --filein file:RelVal_Raw_HIon_DATA.root --fileout file:RelVal_Raw_HIon_DATA_HLT_RECO.root : FAILED - time: date Fri Apr 26 20:31:22 2019-date Fri Apr 26 20:17:12 2019 s - exit: 17920

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26549/34371/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3211964
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3211759
  • DQMHistoTests: Total skipped: 204
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@Martin-Grunewald
Copy link
Contributor

+1

@fabiocos
Copy link
Contributor

@rekovic could you please check?

@kpedro88
Copy link
Contributor

+upgrade

@rekovic
Copy link
Contributor

rekovic commented May 2, 2019

+1

@fabiocos
Copy link
Contributor

fabiocos commented May 2, 2019

+operations

the update of StandardSequences is coherent with the purpose of the PR

@fabiocos
Copy link
Contributor

fabiocos commented May 2, 2019

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 8587c76 into cms-sw:master May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants