Bug fixes for EventSetup consumes corner cases #26550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes 2 bugs. One causes an assert failure and the other an out of bounds read. These bugs were only introduced recently and only in 10_6_X. I am not aware of any existing code that actually hits these corner cases. The assert occurs after a call to setWhatProduced for multiple products followed by another call to setWhatProduced. The out of bounds read failure occurs when esConsumes is called for mutiple types of transitions (event, beginRun, ...) in the same producer, filter, or analyzer. Modifies existing unit tests so the assert bug would now fail a unit test. Modified another test to hit the out of bounds read, although you need valgrind to actually see it with this test, but there is a more involved tests coming soon in the PR that implements concurrent IOVs that fails with the out of bounds read bug. These bugs were noticed while testing the concurrent IOV PR.
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26550/9449
|
|
A new Pull Request was created by @wddgit (W. David Dagenhart) for master. It involves the following packages: FWCore/Framework @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 |
cmsbuild
added
core-approved
fully-signed
and removed
core-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
@Dr15Jones in the header check there is a list of reported errors that seem unrelated to this specific PR, but seem also genuine (i.e. not the usual internal compiler failure). Just to draw your attention to that: |
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
Fixes 2 bugs. One causes an assert failure and the other an out
of bounds read. These bugs were only introduced recently and
only in 10_6_X. The assert occurs for ESProducers that after a
call to setWhatProduced for multiple products call setWhatProduced
another time. The out of bounds read failure occurs when
esConsumes is called for multiple types of transitions (event,
beginRun, ...) in the same producer, filter, or analyzer.
I am not aware of any existing code in CMSSW that actually
hits these corner cases. As far as I know this will not affect the output
of any existing tests.
PR validation:
Modifies existing unit tests so the assert bug would now fail
a unit test. Modified another test to hit the out of bounds read,
although you need valgrind to actually see it with this test, but
there is a new and more complex test coming soon in the PR
that implements concurrent IOVs that fails when the out of bounds
read bug is hit. These bugs were noticed while testing the concurrent
IOV PR.