Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary calls to vector::empty() and vector::clear() from CmsTrackerPhase{1,2TP}DiskBuilder #26553

Merged

Conversation

makortel
Copy link
Contributor

PR description:

There is no need to call clear() to an default-constructor std::vector, and calling empty() without checking the return value has no effect. This PR suggests to remove such unnecessary calls from CmsTrackerPhase1DiskBuilder and CmsTrackerPhase2TPDiskBuilder. These were found by GCC 9.

PR validation:

The code compiles without warnings with GCC 9.

@makortel makortel changed the title Remove unnecessary calls to vector::empty() and vector::clear() from CmsTrakcerPhase{1.2TP}DiskBuilder Remove unnecessary calls to vector::empty() and vector::clear() from CmsTrakcerPhase{1,2TP}DiskBuilder Apr 26, 2019
@cmsbuild cmsbuild added this to the CMSSW_10_6_X milestone Apr 26, 2019
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26553/9453

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

Geometry/TrackerNumberingBuilder

@civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@ebrondol, @VinInn, @venturia this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor Author

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 26, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34375/console Started: 2019/04/26 22:08

@makortel makortel changed the title Remove unnecessary calls to vector::empty() and vector::clear() from CmsTrakcerPhase{1,2TP}DiskBuilder Remove unnecessary calls to vector::empty() and vector::clear() from CmsTrackerPhase{1,2TP}DiskBuilder Apr 26, 2019
@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26553/34375/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3211964
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3211759
  • DQMHistoTests: Total skipped: 204
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@cvuosalo
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit f7a2ccf into cms-sw:master Apr 29, 2019
@makortel makortel deleted the fixGccGeometryTrackerNumberingBuilder branch April 29, 2019 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants