New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unnecessary calls to vector::empty() and vector::clear() from CmsTrackerPhase{1,2TP}DiskBuilder #26553
Remove unnecessary calls to vector::empty() and vector::clear() from CmsTrackerPhase{1,2TP}DiskBuilder #26553
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26553/9453
|
A new Pull Request was created by @makortel (Matti Kortelainen) for master. It involves the following packages: Geometry/TrackerNumberingBuilder @civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
There is no need to call
clear()
to an default-constructorstd::vector
, and callingempty()
without checking the return value has no effect. This PR suggests to remove such unnecessary calls fromCmsTrackerPhase1DiskBuilder
andCmsTrackerPhase2TPDiskBuilder
. These were found by GCC 9.PR validation:
The code compiles without warnings with GCC 9.