Initial PPS Simulation Geometry PR #26555

mundim · 2019-04-26T21:16:56Z

PR description:

PR with the Geometry related files only (new and modified ones) for the PPS simulation

PR validation:

It has passed through a reviewing process for which
scram b code-checks
was already ran

This one has been rebased and now, also:
scram b code-format
was ran, together with

scram b runtests
runTheMatrix.py which gave the output:
21 17 16 15 8 1 0 0 0 tests passed, 12 3 0 0 0 0 0 0 0 failed

if this PR is a backport please specify the original PR:

Before submitting your pull requests, make sure you followed this checklist:

verify that the PR is really intended for the chosen branch
verify that changes follow CMS Naming, Coding, And Style Rules
verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

cmsbuild · 2019-04-26T21:18:19Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-04-26T21:23:59Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26555/9455

This PR adds an extra 40KB to repository

cmsbuild · 2019-04-26T21:25:20Z

A new Pull Request was created by @mundim for master.

It involves the following packages:

Configuration/Geometry
Geometry/CMSCommonData
Geometry/VeryForwardData
Geometry/VeryForwardGeometry

@civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @forthommel, @jan-kaspar, @vargasa this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

kpedro88 · 2019-04-26T21:30:48Z

please test

cmsbuild · 2019-04-26T21:31:20Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34377/console Started: 2019/04/26 23:31

cmsbuild · 2019-04-26T23:03:19Z

+1
Tested at: 5b61fe1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26555/34377/summary.html

cmsbuild · 2019-04-26T23:03:25Z

Comparison job queued.

cmsbuild · 2019-04-27T01:12:41Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26555/34377/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 3 differences found in the comparisons
DQMHistoTests: Total files compared: 33
DQMHistoTests: Total histograms compared: 3211964
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3211759
DQMHistoTests: Total skipped: 204
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
Checked 137 log files, 14 edm output root files, 33 DQM output files

civanch · 2019-04-30T13:26:54Z

@kpedro88 , @cvuosalo , @ianna , this PR is a geometry part of a big PR for PPS, which we asked to split. Would it be possible to review it?

kpedro88 · 2019-04-30T15:06:40Z

Geometry/VeryForwardGeometry/interface/CTPPSPixelSimTopology.h

+                         double& lower_y,
+                         double& higher_y) const {
+    // x and y in the system  of Geant4 SIMULATION
+    arow = 159 - arow;


This class seems to be full of magic numbers. These are not new in this PR, but at some point they should be replaced with named constants (or even better, obtained from geometry XML specifications in case any of them changes in the future).

kpedro88 · 2019-04-30T15:07:35Z

+upgrade

cmsbuild · 2019-05-07T14:28:40Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26555/9650

This PR adds an extra 44KB to repository

cmsbuild · 2019-05-07T14:29:20Z

Pull request #26555 was updated. @civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please check and sign again.

ianna · 2019-05-07T16:57:38Z

please test

cmsbuild · 2019-05-07T16:58:11Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/56/console Started: 2019/05/07 19:00

cmsbuild · 2019-05-07T18:37:52Z

+1
Tested at: 0079d82
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5acd43/56/summary.html

cmsbuild · 2019-05-07T18:37:59Z

Comparison job queued.

cmsbuild · 2019-05-07T20:55:22Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5acd43/56/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 33
DQMHistoTests: Total histograms compared: 3211964
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3211759
DQMHistoTests: Total skipped: 204
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
Checked 137 log files, 14 edm output root files, 33 DQM output files

kpedro88 · 2019-05-11T20:59:45Z

+upgrade

cvuosalo · 2019-05-14T22:33:36Z

+1

cmsbuild · 2019-05-14T22:34:25Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

fabiocos · 2019-05-16T08:41:49Z

+1

this looks now ready to enter

Initial PPS Simulation Geometry

5b61fe1

cmsbuild added this to the CMSSW_10_6_X milestone Apr 26, 2019

cmsbuild added code-checks-pending comparison-pending geometry-pending orp-pending pending-signatures tests-pending upgrade-pending labels Apr 26, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 26, 2019

cmsbuild added tests-started and removed tests-pending labels Apr 26, 2019

cmsbuild added tests-approved and removed tests-started labels Apr 26, 2019

cmsbuild added comparison-available and removed comparison-pending labels Apr 27, 2019

kpedro88 reviewed Apr 30, 2019

View reviewed changes

cmsbuild added upgrade-approved and removed upgrade-pending labels Apr 30, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels May 7, 2019

cmsbuild added tests-started and removed tests-pending labels May 7, 2019

cmsbuild added tests-approved and removed tests-started labels May 7, 2019

cmsbuild added comparison-available and removed comparison-pending labels May 7, 2019

cmsbuild added upgrade-approved and removed upgrade-pending labels May 11, 2019

smuzaffar modified the milestones: CMSSW_10_6_X, CMSSW_11_0_X May 14, 2019

cmsbuild added fully-signed geometry-approved and removed geometry-pending pending-signatures labels May 14, 2019

cmsbuild added orp-approved and removed orp-pending labels May 16, 2019

cmsbuild merged commit 07c6317 into cms-sw:master May 16, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Initial PPS Simulation Geometry PR #26555

Initial PPS Simulation Geometry PR #26555

mundim commented Apr 26, 2019

cmsbuild commented Apr 26, 2019

cmsbuild commented Apr 26, 2019

cmsbuild commented Apr 26, 2019

kpedro88 commented Apr 26, 2019

cmsbuild commented Apr 26, 2019 •

edited

cmsbuild commented Apr 26, 2019

cmsbuild commented Apr 26, 2019

cmsbuild commented Apr 27, 2019

civanch commented Apr 30, 2019 •

edited

kpedro88 Apr 30, 2019

kpedro88 commented Apr 30, 2019

cmsbuild commented May 7, 2019

cmsbuild commented May 7, 2019

ianna commented May 7, 2019

cmsbuild commented May 7, 2019 •

edited

cmsbuild commented May 7, 2019

cmsbuild commented May 7, 2019

cmsbuild commented May 7, 2019

kpedro88 commented May 11, 2019

cvuosalo commented May 14, 2019

cmsbuild commented May 14, 2019

fabiocos commented May 16, 2019

Initial PPS Simulation Geometry PR #26555

Initial PPS Simulation Geometry PR #26555

Conversation

mundim commented Apr 26, 2019

PR description:

PR validation:

if this PR is a backport please specify the original PR:

cmsbuild commented Apr 26, 2019

cmsbuild commented Apr 26, 2019

cmsbuild commented Apr 26, 2019

kpedro88 commented Apr 26, 2019

cmsbuild commented Apr 26, 2019 • edited

cmsbuild commented Apr 26, 2019

cmsbuild commented Apr 26, 2019

cmsbuild commented Apr 27, 2019

civanch commented Apr 30, 2019 • edited

kpedro88 Apr 30, 2019

Choose a reason for hiding this comment

kpedro88 commented Apr 30, 2019

cmsbuild commented May 7, 2019

cmsbuild commented May 7, 2019

ianna commented May 7, 2019

cmsbuild commented May 7, 2019 • edited

cmsbuild commented May 7, 2019

cmsbuild commented May 7, 2019

cmsbuild commented May 7, 2019

kpedro88 commented May 11, 2019

cvuosalo commented May 14, 2019

cmsbuild commented May 14, 2019

fabiocos commented May 16, 2019

cmsbuild commented Apr 26, 2019 •

edited

civanch commented Apr 30, 2019 •

edited

cmsbuild commented May 7, 2019 •

edited