Fix dressed lepton constituents, add tau ghosts

[mseidel42]

PR description:

• Rivet 2.7.0 requires changes to access dressed lepton constituents (= bare lepton + photons). This did not impact any calculations done with the dressed lepton as a whole.
• Added ghost tau ancestors to identify electrons/muons from tau decays.

PR validation:

Tested on ttbar sample, number of dressed lepton constituents has entries >1 as expected again. Tau ghosts increase number of constituents and show up in the tags collection.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26616/9571

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @intrepid42 (Markus Seidel) for master.

It involves the following packages:

GeneratorInterface/RivetInterface

@alberto-sanchez, @cmsbuild, @qliphy, @perrozzi, @efeyazgan can you please review it and eventually sign? Thanks.
@alberto-sanchez, @agrohsje, @mkirsano this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[qliphy]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34488/console Started: 2019/05/03 22:44

[cmsbuild]

+1
Tested at: 61a9b1c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26616/34488/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26616/34488/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3211964
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3211759
• DQMHistoTests: Total skipped: 204
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[qliphy]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1

[peruzzim]

@intrepid42: discussing with @emanca, I understand this feature is meant to support analysis. Should it be backported to 10_2_X? Is it going to affect the products in ongoing production campaigns?

[mseidel42]

@peruzzim Yes, it would be great to have this in centrally produced nanoAod. It adds one tag particle for the dressed lepton GenJets. Please let us know when it would be fine to insert this change. The code needed for 10_2_X will be a bit different because of the older Rivet version there.

[peruzzim]

The question is, whether merging this code (or an equivalent version of it, because of different Rivet version) will change the output of MINIAOD production in 10_2_X. If so, it would be a problem because there are ongoing production campaigns in 10_2_X. I think we have nothing calling this code in MINIAOD production, but could you please verify this point?

[mseidel42]

This is not run in MINIAOD production. Only at analysis level and nanoAod.

[peruzzim]

good, then I would say you can backport it immediately - thanks