Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running code-format for dqm #26619

Merged
merged 2 commits into from May 7, 2019
Merged

Running code-format for dqm #26619

merged 2 commits into from May 7, 2019

Conversation

cmsbuild
Copy link
Contributor

@cmsbuild cmsbuild commented May 3, 2019

Applying code-format for CMSSW category dqm.
See the build logs here https://cmssdt.cern.ch/jenkins/job/GitHub-refactor-cmssw-module/160//console

@cmsbuild
Copy link
Contributor Author

cmsbuild commented May 3, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor Author

cmsbuild commented May 3, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26619/9577

  • This PR adds an extra 8KB to repository

@cmsbuild
Copy link
Contributor Author

cmsbuild commented May 3, 2019

A new Pull Request was created by @cmsbuild for master.

It involves the following packages:

DQM/EcalPreshowerMonitorClient
DQM/HLXMonitor
DQM/PhysicsObjectsMonitoring
DQM/RCTMonitor
DQM/SiOuterTracker
DQM/SiPixelCommon
DQM/SiPixelMonitorTrack
DQM/SiStripHistoricInfoClient
DQM/SiStripMonitorPedestals
DQM/TrackerMonitorTrack
DQM/TrigXMonitorClient
DQMOffline/CalibMuon
HLTriggerOffline/B2G
HLTriggerOffline/JetMET
HLTriggerOffline/Tau
HLTriggerOffline/Top
Validation/CSCRecHits
Validation/EcalHits
Validation/EcalRecHits
Validation/GlobalHits
Validation/L1T
Validation/MuonGEMRecHits
Validation/MuonIdentification
Validation/MuonME0Validation
Validation/RPCRecHits
Validation/RecoJets
Validation/RecoMET
Validation/RecoPixelVertexing
Validation/SiPixelPhase1DigisV
Validation/SiPixelPhase1HitsV
Validation/SiPixelPhase1TrackClustersV
Validation/SiPixelPhase1TrackingParticleV
Validation/TrackerDigis
Validation/TrackerHits
Validation/TrackingMCTruth

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@TaiSakuma, @abbiendi, @rappoccio, @argiro, @jshlee, @fioriNTU, @thomreis, @ahinzmann, @threus, @seemasharmafnal, @mmarionncern, @hdelanno, @battibass, @makortel, @jhgoh, @jdolen, @HuguesBrun, @trocino, @schoef, @rociovilar, @jdamgov, @nhanvtran, @gkasieczka, @jandrea, @idebruyn, @mtosi, @clelange, @calderona, @mariadalfonso, @folguera this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor Author

cmsbuild commented May 3, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34490/console Started: 2019/05/03 23:37

@cmsbuild
Copy link
Contributor Author

cmsbuild commented May 4, 2019

@cmsbuild
Copy link
Contributor Author

cmsbuild commented May 4, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor Author

cmsbuild commented May 4, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26619/34490/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3211964
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3211759
  • DQMHistoTests: Total skipped: 204
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@andrius-k
Copy link

+1

@cmsbuild
Copy link
Contributor Author

cmsbuild commented May 7, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented May 7, 2019

+1

@cmsbuild cmsbuild merged commit f686c84 into master May 7, 2019
@smuzaffar smuzaffar deleted the code-format-dqm-52ae65 branch May 31, 2019 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants