[HeaderCheck][RECO1] Cleanup headers to avoid header inconsistency errors

[smuzaffar]

• removed obsolete headers
• all of these are already marked to be delete
  • RecoTracker/Record/interface/Records.h is not used by any thing

[smuzaffar]

please test

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26656/9617

• This PR adds an extra 12KB to repository

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/34529/console Started: 2019/05/06 16:06

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

RecoTracker/CkfPattern
RecoTracker/MeasurementDet
RecoTracker/Record
RecoTracker/TkSeedGenerator

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @mschrode, @gpetruc, @ebrondol, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1
Tested at: fbef1f2
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26656/34529/summary.html

[cmsbuild]

Comparison job queued.

[slava77]

it would be better to delete obviously obsolete files separately from those that contain real code which may be used in some analysis and could require a revert/recovery

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-26656/34529/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3211964
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3211759
• DQMHistoTests: Total skipped: 204
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[perrotta]

+1

• Technical:
  • all removed headers are obsolete
  • RecoTracker/Record/interface/Records.h is never used, and it is also wrong as it refers to a non-existing "RecoTracker/Records" (with final "s") package

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1