MTV : adjust impact parameter selection #26700
Conversation
…ixel detector (for phase1 : bug fix, for phase2 : new feature)
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26700/9680
|
|
A new Pull Request was created by @mtosi (mia tosi) for master. It involves the following packages: Validation/RecoTrack @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
it would be useful to have it backported to earlier release as well |
| phase2_tracker.toModify(TpSelectorForEfficiencyVsEtaBlock, minRapidity=-4.5, maxRapidity=4.5) | ||
|
|
||
| run3_common.toModify(generalTpSelectorBlock, _modifyForPhase1) | ||
| run3_common.toModify(TpSelectorForEfficiencyVsEtaBlock, _modifyForPhase1) |
There was a problem hiding this comment.
Use of run3_common is redundant as phase1Pixel modifier is included in Run3 era.
There was a problem hiding this comment.
thanks @makortel
I'll delete these lines, then
| from Configuration.Eras.Modifier_phase2_tracker_cff import phase2_tracker | ||
| phase1Pixel.toModify(GenParticleSelectionForEfficiency,minRapidityGP = -3.0, maxRapidityGP = 3.0) | ||
| run3_common.toModify(GenParticleSelectionForEfficiency,minRapidityGP = -3.0, maxRapidityGP = 3.0) | ||
| phase2_tracker.toModify(GenParticleSelectionForEfficiency,minRapidityGP = -4.5, maxRapidityGP = 4.5) |
There was a problem hiding this comment.
It is probably good to update this file, even if MultiTrackValidatorGenPs has been largely unsupported (at least) for the past ~4.5 years (it might still work though).
They should be kept separate as different things are customized with |
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26700/9682
|
|
Pull request #26700 was updated. @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please check and sign again. |
|
@cmsbuild, please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
@mtosi I understand that this PR is needed in 10_6_X as well, not only for future releases, am I correct? |
|
ciao, @fabiocos yes indeed, in principle it should be applied everywhere, |
|
@mtosi for 10_6_X I have done the backport, as I preferred to defer the integration. For older cycles please propose possible backports where considered useful |
|
+1 |
|
thanks ! |
[106X] MTV : adjust impact parameter selection (backport of #26700)
PR description:
adjust the impact parameter selection
for avoiding the 1st layer of the pixel detector (for phase1 : bug fix, for phase2 : new feature)
the efficiency plots produced by the MTV will be affected
in the phase1, run3 and phase2_tracker era
I have a question on the different eras in phase2
the MTV still makes use of either
Modifier_phase2_tracker_cff.py
or
Modifier_phase2_timing_layer_cff.py
shall we move to
Modifier_phase2_common_cff.py ?
PR validation:
scram b runtestsrunTheMatrix.py -l limited -i all --ibeosdone