NanoAOD developments: 190508 version, part 1 for UL #26703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update master-cmsswmaster to CMSSW_10_4_0
Port PR 286 to 104X
…ions Fix module label in IsFromLostTrackMapProducer::fillDescriptions()
[RFC] Call nanoAOD_runMETfixEE2017() only if the modifiers are chosen
Following the discussion in #283
Don't leave nCuts in VIDNestedWPBitmapProducer uninitialized
Fix for trigger objects for muons in 2016 NanoAOD [104X]
Update master branch to 10_6_0_pre3
To make it more clear that the plugins are actually specializations of SimpleFlatTableProducer templates.
3 more deepTag scores so that the raw values for W, Z, H, T, QCDbc, and QCDudsg can be calculated
Default range of 0 to 1
`GenParticle::isPrompt` does not exist.
Port PR 294 300 305 to master
Port PR 276 to master
Port PR 318 to master
|
Comparison is ready Comparison Summary:
|
|
+xpog runs for all NANOAOD validation workflows |
|
Which is the purpose within this PR of the modifications in JetMETCorrections/Type1MET/interface/JetCleanerForType1METT.h, i.e. the calculation of muon-subtracted raw pt? They are disbled by default, and they would also need a further addition to the event content to become effective, but I wonder how do they relate with the other nanoAOD related updates, |
|
The feature is used in nanoAOD production to store that definition of raw pt for jets, so they can be used for T1 MET correction. I update the description. cmssw/PhysicsTools/NanoAOD/python/nano_cff.py Line 177 in f92240c |
|
+1
|
|
@smuzaffar FYI There is a long list od header checks error. They are real but do not refer to this PR:
|
|
+1 |
|
merge |
|
+1 |
cmsbuild
added
analysis-approved
fully-signed
and removed
analysis-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
|
if and similar does this mean that is actually never references an shall be removed? |
See #26663 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
This PR contains the developments accumulated so far for NanoAOD in 10_6_X, for UL and full Run2 analyses. No change is expected outside of NANOAOD content.
Main updates:
Depends on cms-sw/cmsdist#4937 for updated lepton MVA weights.
Further optimization (in particular, using some added content to 10_6_X MINIAOD instead of recalculating the same information) will come as a future PR, together with what depends on still-open items for the UL, and minor additions if available in time.
Please test all available NANOAOD workflows with #26672.
Includes a new feature (deactivated by default) in the JetCleanerForType1METT class, to produce a ValueMap with the muon-subtracted raw jet pt as it is used inside the T1 MET correction algorithm. This feature is used in NANOAOD production.
PR validation:
The base branch was tested in several releases as a part of the integration in the cms-nanoAOD repository, and in a subset of them for the branch merged with a recent IB.