Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running code-format for alca #26711

Merged
merged 1 commit into from May 10, 2019
Merged

Running code-format for alca #26711

merged 1 commit into from May 10, 2019

Conversation

cmsbuild
Copy link
Contributor

@cmsbuild cmsbuild commented May 9, 2019

Applying code-format for CMSSW category alca.
See the build logs here https://cmssdt.cern.ch/jenkins/job/GitHub-refactor-cmssw-module/195//console

cms-bot has successfully run the following:

  • scram build code-checks-all
  • scram build code-format-all
  • scram build

Fixes the code-formats suggested by #26630 (see #26686)

@cmsbuild
Copy link
Contributor Author

cmsbuild commented May 9, 2019

please test

@cmsbuild
Copy link
Contributor Author

cmsbuild commented May 9, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor Author

cmsbuild commented May 9, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26711/9697

  • This PR adds an extra 8KB to repository

@cmsbuild
Copy link
Contributor Author

cmsbuild commented May 9, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/103/console Started: 2019/05/09 06:24

@cmsbuild
Copy link
Contributor Author

cmsbuild commented May 9, 2019

A new Pull Request was created by @cmsbuild for master.

It involves the following packages:

Alignment/CommonAlignmentParametrization
Alignment/LaserAlignmentSimulation
CalibCalorimetry/EcalPedestalOffsets
CalibFormats/CaloObjects
CalibMuon/CSCCalibration
Calibration/TkAlCaRecoProducers

@christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @pohsun can you please review it and eventually sign? Thanks.
@pakhotin, @adewit, @tocheng, @argiro, @ptcox, @tlampen, @mschrode, @mmusich, @threus this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor Author

cmsbuild commented May 9, 2019

@cmsbuild
Copy link
Contributor Author

cmsbuild commented May 9, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor Author

cmsbuild commented May 9, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3249e5/103/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3211964
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3211759
  • DQMHistoTests: Total skipped: 204
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@pohsun
Copy link

pohsun commented May 9, 2019

+1

@cmsbuild
Copy link
Contributor Author

cmsbuild commented May 9, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 2348fb9 into master May 10, 2019
@smuzaffar smuzaffar deleted the code-format-alca-91bbb2 branch May 31, 2019 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants