Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CandRefHelper.cc, seems to be not used. #2674

Merged
merged 1 commit into from Mar 12, 2014
Merged

Remove CandRefHelper.cc, seems to be not used. #2674

merged 1 commit into from Mar 12, 2014

Conversation

ghost
Copy link

@ghost ghost commented Feb 28, 2014

Spotted this file trying to fix some warnings going off when compiling on gcc490.
It gives a warning on this file of the kind "Unused function", but probably the compiler misunderstand the statement of the class thinking it's actually a function.
Previous compilers didn't spot this, @vadler should we remove this file or can you find a fix for it?

Spotted this file trying to fix some warnings going off when compiling on gcc490.
It gives a warning on this file of the kind "Unused function", but probably the compiler misunderstand the statement of the class thinking it's actually a function.
Previous compilers didn't spot this, @vadler should we remove this file or can you find a fix for it?
@ghost ghost added analysis-pending labels Feb 28, 2014
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Degano (Alessandro Degano) for CMSSW_7_1_X.

Remove CandRefHelper.cc, seems to be not used.

It involves the following packages:

PhysicsTools/PatUtils

@nclopezo, @vadler, @cmsbuild, @Degano, @monttj can you please review it and eventually sign? Thanks.
@TaiSakuma, @nhanvtran this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@ghost ghost added analysis-pending labels Feb 28, 2014
@nclopezo nclopezo modified the milestones: CMSSW_7_1_0_pre5, CMSSW_7_1_0_pre4 Mar 10, 2014
@vadler
Copy link

vadler commented Mar 11, 2014

+1
This file only tested compilation back in 2008 (s. inlined comment). Farewell....

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

ktf added a commit that referenced this pull request Mar 12, 2014
gcc 4.9.0 -- Remove CandRefHelper.cc, seems to be not used.
@ktf ktf merged commit 75bff28 into cms-sw:CMSSW_7_1_X Mar 12, 2014
@ghost ghost deleted the remove_candrefhelper_71Xgcc490 branch May 15, 2014 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants