Thread safe changes

[ktf]

Forward port of #1292.

[cmsbuild]

A new Pull Request was created by @ktf (Giulio Eulisse) for CMSSW_7_1_X.

Thread safe changes

It involves the following packages:

DataFormats/TrackerCommon

@nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[cmsbuild]

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2675/320/summary.html

[slava77]

@venturia
Hi Andrea,

ClusterSummary reorganization has been on the list for quite some time now.
Has there been any progress here?
How are the use cases developing, btw? Can we expect from the past experience that only a fixed (pre-compiled) set of information is needed for storage?

Please comment

Thanks

[venturia]

@slava77 , @threus
Hi Slava,
honestly as deputy tracker project manager there is little room for me to do software development and fulfill deadlines. At the time this issue was discussed I prepared this:
https://its.cern.ch/jira/browse/CMSTRACK-51
which is still valid.

[anton-a]

No changes on the reco side. The ClusterSummary info is filled as before.

[anton-a]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

[VinInn]

CMS cannot afford to run the present version of ClusterSummary in production.
Either is modified, as foreseen, before data taking, or a plan B (read remove and do w/o) is needed

[venturia]

@VinInn ,
the product of ClusterSummary is used for analysis tools so cannot afford to remove it either. Vincenzo, can you have a look at the Jira issue where I have listed the changes I would like to see done to be sure you agree on that?
If this becomes a real problem I would suggest to rise the issue at the XEB level.

[VinInn]

@venturia, @davidlange6
Andrea, we discussed this last year and agreed. Your plan in Jira is sound. I though it was under execution. I sincerely hope that Tracker DPG will be able to find resources to complete it before the end of the year. Up to you to escalate it if you fell that a larger involvement of the collaboration is needed.

[threus]

Hello all,

initially I supposed to make the changes described in JIRA already last year, but due to the various constrains, it was left unfinished that time. I will be able to work on it in one-two weeks due to other ongoing tasks and to get it done still for 71X.

[VinInn]

given the above commitment I would suggest to close this PR and wait for the new code.

[slava77]

@Dr15Jones @ktf
I'd leave this up to Giulio and Chris to decide.
This change in this PR is driven by thread safety requirements.

[Dr15Jones]

Given this change doesn't make the problems with the ClusterSummary worse and does fix threading issues, I'd say go ahead and merge. This would also, hopefully, serve as a reminder that the new code must be thread-safe.

[ktf]

@threus can you do a pull request with what you have so far? If there is no major overlap (yet) I'd rather merge this than wait for something which is so far did not get much attention.

[threus]

Unfortunately what I have is really not usable and surely not tested.

On 04 Mar 2014, at 21:32, Giulio Eulisse notifications@github.com wrote:

@threus can you do a pull request with what you have so far? If there is no major overlap (yet) I'd rather merge this than wait for something which is so far did not get much attention.

—
Reply to this email directly or view it on GitHub.

[ktf]

does not matter, I just want to check if there is any overlap so far, if
no, we can simply merge valentin stuff.

On 4 Mar 2014, at 23:17, threus wrote:

Unfortunately what I have is really not usable and surely not tested.

On 04 Mar 2014, at 21:32, Giulio Eulisse notifications@github.com
wrote:

@threus can you do a pull request with what you have so far? If there
is no major overlap (yet) I'd rather merge this than wait for
something which is so far did not get much attention.

—
Reply to this email directly or view it on GitHub.

---

Reply to this email directly or view it on GitHub:
#2675 (comment)

[davidlange6]

@ktf - seems we should merge this?

[davidlange6]

@ktf -ping??