Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run2-hcx197 Modify testing of Run3 geometry #26750

Merged
merged 1 commit into from May 18, 2019

Conversation

bsunanda
Copy link
Contributor

PR description:

Make test codes relevant for Run3 HCAL geometry

PR validation:

Tested with runTheMatrix.py with -l limited

if this PR is a backport please specify the original PR:

None

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26750/9744

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Geometry/HcalCommonData
Geometry/HcalTowerAlgo
Validation/HcalHits

@andrius-k, @Dr15Jones, @kmaeshima, @cvuosalo, @schneiml, @ianna, @mdhildreth, @cmsbuild, @jfernan2, @fioriNTU, @civanch can you please review it and eventually sign? Thanks.
@hatakeyamak this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 11, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/159/console Started: 2019/05/11 07:58

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-35c979/159/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-35c979/11624.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2021_GenSimFull+DigiFull_2021+RecoFull_2021+HARVESTFull_2021+ALCAFull_2021

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3211964
  • DQMHistoTests: Total failures: 132
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3211628
  • DQMHistoTests: Total skipped: 204
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@cvuosalo
Copy link
Contributor

+1

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

@bsunanda @cvuosalo it seems to me that the test geometries modified here are then no more used in the test cfgs, which are now based on DB. Could you please clarify the purpose of the changes?

@fabiocos
Copy link
Contributor

@bsunanda @cvuosalo could you please address my question?

@cvuosalo
Copy link
Contributor

@fabiocos: The purpose of this PR would be best explained by @bsunanda.

@bsunanda
Copy link
Contributor Author

I was checking if the changes which I made to geometry code works fine with all earlier geometries and there I wanted to check with the XML geometry first. If the tests are successful with XML geometry it will work for DB geometry.

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit d4df973 into cms-sw:master May 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants