Running code-format for simulation

[cmsbuild]

Applying code-format for CMSSW category simulation.
See the build logs here https://cmssdt.cern.ch/jenkins/job/GitHub-refactor-cmssw-module/212//console

cms-bot has successfully run the following:

• scram build code-checks-all
• scram build code-format-all
• scram build

[cmsbuild]

please test

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26755/9749

• This PR adds an extra 8KB to repository

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/165/console Started: 2019/05/11 12:18

[cmsbuild]

A new Pull Request was created by @cmsbuild for master.

It involves the following packages:

DataFormats/DTDigi
IOMC/EventVertexGenerators
SimCalorimetry/EcalSelectiveReadoutAlgos
SimDataFormats/TrackingAnalysis
SimG4CMS/Forward
SimG4CMS/HcalTestBeam
SimG4CMS/ShowerLibraryProducer
SimGeneral/PreMixingModule
SimMuon/RPCDigitizer

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@battibass, @makortel, @abbiendi, @jhgoh, @argiro, @calderona, @HuguesBrun, @rovere, @ebrondol, @trocino, @folguera this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1
Tested at: 8c72684
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d44965/165/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d44965/165/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-d44965/11624.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2021_GenSimFull+DigiFull_2021+RecoFull_2021+HARVESTFull_2021+ALCAFull_2021

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3211964
• DQMHistoTests: Total failures: 131
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3211629
• DQMHistoTests: Total skipped: 204
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[civanch]

+1
@smuzaffar , @fabiocos, there is a compilation problem in

CommonTools/RecoAlgos/interface/PhotonSelector.h

which has no relation to this PR.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[smuzaffar]

thanks @civanch to double check. Yes CommonTools/RecoAlgos/interface/PhotonSelector.h is not needed and suppose to be removed once #26697 is merged

[fabiocos]

+1