Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compile errors debug flag #2679

Merged
merged 2 commits into from Mar 3, 2014

Conversation

cerati
Copy link
Contributor

@cerati cerati commented Feb 28, 2014

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @cerati for CMSSW_7_1_X.

Fix compile errors debug flag

It involves the following packages:

DataFormats/MuonDetId
RecoTracker/TrackProducer
TrackingTools/TrackFitters

@civanch, @nclopezo, @mdhildreth, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please review it and eventually sign? Thanks.
@ghellwig, @gpetruc, @GiacomoSguazzoni, @rovere this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

CSCDetId( int iendcap, int istation,
int iring, int ichamber,
int ilayer = 0 );

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise the implementation in the .cc file is not seen...

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2014

@civanch
Copy link
Contributor

civanch commented Mar 3, 2014

+1

@slava77
Copy link
Contributor

slava77 commented Mar 3, 2014

+1

for #2679 59099f3

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

nclopezo added a commit that referenced this pull request Mar 3, 2014
@nclopezo nclopezo merged commit e1a93b8 into cms-sw:CMSSW_7_1_X Mar 3, 2014
@nclopezo nclopezo modified the milestones: CMSSW_7_1_0_pre5, CMSSW_7_1_0_pre4 Mar 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants