Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update of DeepTauID to ver. 2017v2 #26796

Merged

Conversation

mbluj
Copy link
Contributor

@mbluj mbluj commented May 16, 2019

PR description:

This PR updates DeepTauID to version 2017v2. The new version, thanks to revised structure of used DNN, fixes issues of version 2017v1 that is a size of training files and memory consumption are greatly reduced. Possibility to run previous version is maintained.

DeepTauID (2017v2) is added to the tau sequence in the standard MiniAOD workflow.

Performance with 1k ttbar events:

In addition the new v2 training overperforms (physics-result-wise) old v1 one as well as other TauIDs, details in slides:

Note 1: this PR is meant to be backported to 10_6_X for UL processing and to 10_2_X for using with current Run-2 samples.
Note 2: this PR is completed by PR to cms-data cms-data/RecoTauTag-TrainingFiles#3 which needs to be propagated to cms-dist.
Note 3: DeepTau 2017v2 is added to MiniAOD workflow with 11_0_X and 10_6_X (UL), while not in the backport to 10_2_X.

PR validation:

Validated with matrix tests; requires cms-data/RecoTauTag-TrainingFiles#3 for unit tests

if this PR is a backport please specify the original PR:

N/A

kandrosov and others added 30 commits April 18, 2019 17:12
motifications for the TauBlockInputs
Improved CellGrid implementation.
Modificacion to add v2 in the python config
@mbluj
Copy link
Contributor Author

mbluj commented Jun 5, 2019

Currently tauID in MiniAOD samples is routinely (as part of RelVal campaigns) validated with standalone (python+ROOT-based) Tau POG tools, i.e. tools not integrated with central DQM workflows. We plan to add DeepTauID to these tools which is rather trivial task.
There is also plan to add MiniAOD validation to DQM workflows which will for instance support validation of features added to CMSSW via unitTests.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4b3e66/784/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 220 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3210222
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3209887
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@perrotta
Copy link
Contributor

perrotta commented Jun 6, 2019

+1

  • New ID provides impressive improvement in physics performance
  • CPU time ~0.09s/evt (tested on TT sample), about 9% of the miniAOD processing time for that sample
    • Factor 3 reduction since the first version of this PR
    • It is probably still acceptable for miniAOD production, but a bit too much for routine nanoAOD production: some further reduction should be attempted if that ID will have to be recomputed in the nanoAOD campaigns: github issue Reduce cpu for DeepTauID 2017v2 #27119 has been opened to keep track of the future improvements in cpu performance
  • Jenkins tests show the additional IDs in miniAOD outputs as only differences
  • This has to be merged together with the external in Training file for DeepTauID 2017v2 cms-data/RecoTauTag-TrainingFiles#3

@fabiocos
Copy link
Contributor

fabiocos commented Jun 6, 2019

@civanch @santocch could you please check this PR?

@civanch
Copy link
Contributor

civanch commented Jun 6, 2019

+1

@santocch
Copy link

santocch commented Jun 7, 2019

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Jun 9, 2019

+1

@cmsbuild cmsbuild merged commit bddb9ab into cms-sw:master Jun 9, 2019
@mbluj mbluj deleted the CMSSW_10_6_X_tau-pog_DeepTau2017v2 branch October 10, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants