Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tunesetforpythia8vgt235 #26802

Merged
merged 2 commits into from May 17, 2019
Merged

Tunesetforpythia8vgt235 #26802

merged 2 commits into from May 17, 2019

Conversation

efeyazgan
Copy link
Contributor

Updating tunes to account for changes in pythia8 version >= 2.3.5

Please see slide 7 of https://indico.cern.ch/event/810088/sessions/307594/attachments/1824497/2990874/pcgt_GEN_Apr_10_2019.pdf

@cmsbuild cmsbuild added this to the CMSSW_11_0_X milestone May 16, 2019
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26802/9806

  • This PR adds an extra 28KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @efeyazgan (Efe Yazgan) for master.

It involves the following packages:

Configuration/Generator

@alberto-sanchez, @cmsbuild, @qliphy, @agrohsje, @efeyazgan can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@efeyazgan
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 16, 2019 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/258/console Started: 2019/05/16 15:16

@cmsbuild
Copy link
Contributor

-1

Tested at: 872e332

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-082e64/258/summary.html

I found follow errors while testing this PR

Failed tests: AddOn

  • AddOn:

I found errors in the following addon tests:

cmsRun /cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc700/cms/cmssw-patch/CMSSW_11_0_X_2019-05-15-2300/src/PhysicsTools/PatAlgos/test/IntegrationTest_cfg.py : FAILED - time: date Thu May 16 17:10:32 2019-date Thu May 16 17:05:22 2019 s - exit: 23552
cmsDriver.py RelVal -s L1REPACK:Full --data --scenario=pp -n 10 --conditions auto:run2_hlt_Fake2 --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2016 --fileout file:RelVal_Raw_Fake2_DATA.root --filein /store/data/Run2016B/JetHT/RAW/v1/000/272/762/00000/C666CDE2-E013-E611-B15A-02163E011DBE.root : FAILED - time: date Thu May 16 17:17:26 2019-date Thu May 16 17:05:25 2019 s - exit: 23552
cmsRun /cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc700/cms/cmssw-patch/CMSSW_11_0_X_2019-05-15-2300/src/HLTrigger/Configuration/test/OnLine_HLT_Fake2.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Thu May 16 17:17:26 2019-date Thu May 16 17:05:25 2019 s - exit: 21504
cmsDriver.py RelVal -s HLT:Fake2,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_Fake2 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --processName=HLTRECO --filein file:RelVal_Raw_Fake2_DATA.root --fileout file:RelVal_Raw_Fake2_DATA_HLT_RECO.root : FAILED - time: date Thu May 16 17:17:26 2019-date Thu May 16 17:05:25 2019 s - exit: 21504
cmsDriver.py RelVal -s L1REPACK:Full --data --scenario=pp -n 10 --conditions auto:run2_hlt_PRef --relval 9000,50 --datatier "RAW" --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2018 --eventcontent RAW --fileout file:RelVal_Raw_PRef_DATA.root --filein /store/data/Run2017A/HLTPhysics4/RAW/v1/000/295/606/00000/36DE5E0A-3645-E711-8FA1-02163E01A43B.root : FAILED - time: date Thu May 16 17:17:10 2019-date Thu May 16 17:05:26 2019 s - exit: 23552
cmsRun /cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc700/cms/cmssw-patch/CMSSW_11_0_X_2019-05-15-2300/src/HLTrigger/Configuration/test/OnLine_HLT_PRef.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Thu May 16 17:17:10 2019-date Thu May 16 17:05:26 2019 s - exit: 21504
cmsDriver.py RelVal -s HLT:PRef,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_PRef --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018 --processName=HLTRECO --filein file:RelVal_Raw_PRef_DATA.root --fileout file:RelVal_Raw_PRef_DATA_HLT_RECO.root : FAILED - time: date Thu May 16 17:17:10 2019-date Thu May 16 17:05:26 2019 s - exit: 21504
cmsDriver.py RelVal -s L1REPACK:Full --data --scenario=pp -n 10 --conditions auto:run2_hlt_PIon --relval 9000,50 --datatier "RAW" --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2018 --eventcontent RAW --fileout file:RelVal_Raw_PIon_DATA.root --filein /store/data/Run2017A/HLTPhysics4/RAW/v1/000/295/606/00000/36DE5E0A-3645-E711-8FA1-02163E01A43B.root : FAILED - time: date Thu May 16 17:19:58 2019-date Thu May 16 17:09:55 2019 s - exit: 23552
cmsRun /cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc700/cms/cmssw-patch/CMSSW_11_0_X_2019-05-15-2300/src/HLTrigger/Configuration/test/OnLine_HLT_PIon.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Thu May 16 17:19:58 2019-date Thu May 16 17:09:55 2019 s - exit: 21504
cmsDriver.py RelVal -s HLT:PIon,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_PIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018 --processName=HLTRECO --filein file:RelVal_Raw_PIon_DATA.root --fileout file:RelVal_Raw_PIon_DATA_HLT_RECO.root : FAILED - time: date Thu May 16 17:19:58 2019-date Thu May 16 17:09:55 2019 s - exit: 21504

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-082e64/258/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3212004
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3211667
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 17, 2019 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/292/console Started: 2019/05/17 08:39

@cmsbuild
Copy link
Contributor

+1
Tested at: 872e332
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-082e64/292/summary.html

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-082e64/292/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3212004
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3211668
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@efeyazgan
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

@efeyazgan is this update desired for the UL production? If yes this would impact the production of the GEN-SIM PU library, am I correct?

@fabiocos
Copy link
Contributor

@efeyazgan as far as I can see, for the pdf this is just a renaming but the actual pdf does not change, am I correct?

@efeyazgan
Copy link
Contributor Author

@fabiocos yes this is for UL production. We had already produced the minbias using these settings, So, we should be fine. Now with this, we are generalizing it to all samples.

keeping @pgunnell in the loop.

@fabiocos
Copy link
Contributor

@efeyazgan @pgunnell ok, but this means that 10_6_0 cannot be used to produce the library, it needs this update at minimum

@efeyazgan
Copy link
Contributor Author

@efeyazgan as far as I can see, for the pdf this is just a renaming but the actual pdf does not change, am I correct?

@fabiocos the access method changed from pythia8 to lhapdf method (pythia8 authors decided to get rid of our main NNLO pdf from pythia8 internal sets). But this one we put as default is the positive-definite version of our pdf set which allows us to use this pdf up to arbitrarily high scales w/o the problem of negative-weights. In the standard model phase space this pdf set and our previous default are equivalent.

@efeyazgan
Copy link
Contributor Author

@efeyazgan @pgunnell ok, but this means that 10_6_0 cannot be used to produce the library, it needs this update at minimum

But we added these settings buy hand in the minbias production with 10_6.

@fabiocos
Copy link
Contributor

@efeyazgan @pgunnell so this means that the settings are passed manually so far, and we will get this in 10_6_1? Please provide a backport for this

@efeyazgan efeyazgan mentioned this pull request May 17, 2019
Merged
@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 156d29f into cms-sw:master May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code-checks-approved comparison-available fully-signed generators-approved orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_11_0_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@efeyazgan @cmsbuild @smuzaffar @fabiocos