Remove PFElectronAlgo and PFPhotonAlgo used back in Run 1 #26813
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26813/9828
|
|
A new Pull Request was created by @guitargeek (Jonas Rembser) for master. It involves the following packages: RecoEgamma/Configuration @perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
happy days :D Thanks Jonas! |
|
What about cleaning since now from the un-needed parameters also the This will get automatically propagated to the HLT configs when they will be parsed next (no need to touch them, therefore: since there is no fillDescritpion in this code, the unneeded parameters remaining in the HLT configs in the meanwhile will not hurt, and there will be no need to customize them, then). I think you should further remove those old parameters from the configs which clones that
|
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26813/9881
|
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1
Once merged, this will affect #26825, as part of the code in PFAlgo.cc which is modified in that PR is removed here. Since one of the two PR's has to be rebased anyhow, I think it it is easier if one first do the removal, and then the modification will be avoided in the other PR |
cmsbuild
added
fully-signed
reconstruction-approved
and removed
pending-signatures
reconstruction-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
Thank you Andrea, that is indeed the easiest way and also what we discussed in jpata#44. |
|
+1 |
PR description:
The old egamma particle flow code has not been used for 5 years but still is strongly entangled with the current particle flow code, which poses an unnecessary maintenance burden. As discussed with @bendavid, @Sam-Harper, @slava77 and @hatakeyamak, a clean-up of the legacy PF egamma code is on our todo list for the 11XY cycle.
I keep things minimal for now so it can be easily reviewed and keep the risk of differences minimal:
usePFPhotons_orusePFPElectrons_)Of course what's still missing is cleaning up the configurations from now unused parameters, of better even implement a
fillDescriptionsmethod for the PFProducer. However, this would require editing various HLT configs which are huge and tedious to edit, so I think that action could be for another PF (or this one after initial tests pass and no differences are observed).Fixes #26658.
PR validation:
CMSSW compiles and matrix tests pass.
if this PR is a backport please specify the original PR:
No backport is intended.