New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add in cmsDriver LHE and GEN as steps defining the isMC option #26819
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26819/9839
|
A new Pull Request was created by @fabiocos (Fabio Cossutti) for master. It involves the following packages: Configuration/Applications @cmsbuild, @franzoni, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
The code-checks are being triggered in jenkins. |
@srimanob this should be the most general addition |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26819/9841
|
please test workflow 503.0,521.0 |
The tests are being triggered in jenkins. |
Pull request #26819 was updated. @cmsbuild, @franzoni, @fabiocos, @davidlange6 can you please check and sign again. |
Comparison job queued. |
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
+1 |
+operations the code has been verified to act as desired, see PR description |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
PR description:
Following #26812 I realize that within cmsDriver the
isMC
options is set according to the step content for several MC-related steps but for theLHE
andGEN
steps. I guess this has only historical reasons, without any explicit desire. This PR just sets the isMC option to True even in the case at least one of these additional steps is required.PR validation:
The output configurations for test wf 503.0 (GEN only) and 521.0 (LHE only) are unchanged. The failing test reported by @srimanob now succeed even without specifying the
--mc
command line option.