[HGCAL trigger] Motherboard description and BestChoice updates. Sim clustering.

[jbsauvan]

PR description:

• Major updates
  • Implement motherboard mapping that depends on the layer
  • Add description of the number of output links per motherboard (provided as external data file)
  • Update the concentrator "BestChoice" selection: can select a variable number of trigger cells based on the motherboard size and the number of links per motherboard
  • Add sim clustering of trigger cells
• Minor updates
  • Improve motherboard definition in the scintillator part
  • Update ntuples
  • Split the concentrator selection algorithms "Threshold" and "BestChoice" into two different classes

Needs external cms-data/L1Trigger-L1THGCal#14

PR validation:

scram b code-checks
scram b code-format
runTheMatrix.py -w upgrade -l 21234.0 --maxSteps=2
runTheMatrix.py -w upgrade -l 27434.0 --maxSteps=2
runTheMatrix.py -w upgrade -l 29034.0 --maxSteps=2

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26820/9840

• This PR adds an extra 216KB to repository

[cmsbuild]

A new Pull Request was created by @jbsauvan (Jean-Baptiste Sauvan) for master.

It involves the following packages:

DataFormats/L1THGCal
L1Trigger/L1THGCal
L1Trigger/L1THGCalUtilities

@cmsbuild, @rekovic, @kpedro88 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @amarini, @rovere, @lgray this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[smuzaffar]

please test with cms-data/L1Trigger-L1THGCal#14

[cmsbuild]

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-data/L1Trigger-L1THGCal#14
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/322/console Started: 2019/05/18 08:57

[cmsbuild]

+1
Tested at: 4e6be31
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-80aeb0/322/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-80aeb0/322/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3211772
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3211436
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[cmsbuild]

Pull request #26820 was updated. @cmsbuild, @rekovic, @kpedro88 can you please check and sign again.

[kpedro88]

please test with cms-data/L1Trigger-L1THGCal#14

[cmsbuild]

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-data/L1Trigger-L1THGCal#14
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/420/console Started: 2019/05/22 15:15

[cmsbuild]

+1
Tested at: ebb546f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-80aeb0/420/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-80aeb0/420/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3209204
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3208869
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[kpedro88]

+upgrade

[rekovic]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1

[makortel]

IBs and tests of other PRs are showing failures like

An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named step2_DIGI_L1_L1TrackTrigger_DIGI2RAW_HLT.py
Exception Message:
 unknown python problem occurred.
RuntimeError: An exception of category 'FileInPathError' occurred.
Exception Message:
edm::FileInPath unable to find file L1Trigger/L1THGCal/data/panel_mapping_jan19_0.txt anywhere in the search path.

in workflows 27434.0, 27434.21, 27634.21, 27834.0, and 29034.0, presumably caused by this PR.

[makortel]

Or it is just that cms-data/L1Trigger-L1THGCal#14 did not enter in the same IB?

[kpedro88]

@makortel yes, I think that's the problem. It should work in the next IB, we'll see...