Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating GT and BeamSpot for 2021 relvals #26828

Conversation

prebello
Copy link
Contributor

This PR cherry-pick the autocond GTs from AlCa PR@26773 and add proper BS for the 2021 relvals.

Local tests without errors.

FYI @zhenhu @pgunnell @boudoul @christopheralanwest @tocheng

PR description:

PR validation:

if this PR is a backport please specify the original PR:

Before submitting your pull requests, make sure you followed this checklist:

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26828/9853

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @prebello (Patricia Rebello Teles) for master.

It involves the following packages:

Configuration/AlCa
Configuration/PyReleaseValidation

@cmsbuild, @prebello, @zhenhu, @christopheralanwest, @tocheng, @pgunnell, @franzoni, @kpedro88, @tlampen, @pohsun can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @mmusich, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@prebello
Copy link
Contributor Author

please test workflow 11671.0,11624.0

@cmsbuild
Copy link
Contributor

cmsbuild commented May 17, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/318/console Started: 2019/05/17 23:18

@prebello
Copy link
Contributor Author

@fabiocos please let me know if I can backport this PR (or simply submit a new PR as the changes are minimal) in 10-6-X. Thank you.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9a8e0f/318/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2541 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3212004
  • DQMHistoTests: Total failures: 8155
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3203515
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@zhenhu
Copy link
Contributor

zhenhu commented May 18, 2019

+1

@christopheralanwest
Copy link
Contributor

+1

@fabiocos
Copy link
Contributor

@kpedro88 I would say it is ok, could you please have a look?

@fabiocos
Copy link
Contributor

@christopheralanwest is this PR supposed to be integrated into a release before the complete GT is available? In other terms is the complete update expected to miss a reasonable timescale for 10_6_1?

@christopheralanwest
Copy link
Contributor

@fabiocos The GT including tracker-alignment-dependent conditions for the 2017 UL is expected within one to two weeks. Run Coordination and PdmV would like to have this PR integrated as soon as possible, prior to 10_6_1, so that default validation workflows use the updated conditions.

@mmusich
Copy link
Contributor

mmusich commented May 20, 2019

@christopheralanwest I am wondering instead what is preventing the delivery in autoCond of the Tracker data conditions proposed in #26773 ?
Please clarifiy.

@kpedro88
Copy link
Contributor

+upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants