Running code-format for hlt-reconstruction #26867
Conversation
|
please test |
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26867/9903
|
|
The tests are being triggered in jenkins. |
|
A new Pull Request was created by @cmsbuild for master. It involves the following packages: RecoMuon/L2MuonIsolationProducer @perrotta, @Martin-Grunewald, @cmsbuild, @fwyzard, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
| const L1MuGMTExtendedCand muonCand = (*it).gmtMuonCand(); | ||
| unsigned int quality = 0; | ||
| bool valid_charge = false;; | ||
| bool valid_charge = false; | ||
| ; |
There was a problem hiding this comment.
@smuzaffar @davidlange6 @fabiocos
this is perhaps something to be added for another round of central cleanups (;; -> ; or drop post-clang-format empty lines terminated with a semicolon).
There was a problem hiding this comment.
@slava77 thanks for the remark. @smuzaffar @davidlange6 As far as I can see this is not strictly speaking wrong, but likely not what we would like to have, the problem is in the ";;" at the origin of this...
|
+1 |
cmsbuild
added
fully-signed
hlt-approved
and removed
hlt-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
Applying code-format for CMSSW category hlt,reconstruction.
See the build logs here https://cmssdt.cern.ch/jenkins/job/GitHub-refactor-cmssw-module/246//console
cms-bot has successfully run the following: