maskCell() bug fix: two masks were swapped

[bfonta]

PR description:

A bug was found in the cell masks that will be eventually used to mask some of the virtual wafers (the masks allow the implementation of partial wafers, such as "fives" or "threes"). Two masks were swapped.

PR validation:

The new masks were tested using RecHits from a particle gun: before correcting the bug and after correcting the bug. The wafers (2,2) and (-2,-2) were not being correctly masked.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26877/9912

• This PR adds an extra 24KB to repository

[cmsbuild]

A new Pull Request was created by @b-fontana for master.

It involves the following packages:

Geometry/HGCalCommonData

@civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[kpedro88]

@bsunanda FYI

[kpedro88]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/419/console Started: 2019/05/22 15:08

[cmsbuild]

+1
Tested at: 4ed6563
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9c8a42/419/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9c8a42/419/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3209204
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3208869
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[cvuosalo]

+1

[kpedro88]

+upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

@b-fontana @kpedro88 is this fix relevant for the forthcoming L1T TDR production?

[bfonta]

@fabiocos No, it is not.

[fabiocos]

+1