Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SimG4: DD Direct Dependency Cleanup #26901

Merged
merged 2 commits into from May 27, 2019

Conversation

ianna
Copy link
Contributor

@ianna ianna commented May 23, 2019

PR description:

  • Move DDG4ProductionCuts class from SimG4Core/Physics package to SimG4Core/Geometry package to avoid direct dependency of the first on DetectorDescription/Core. Only the latter should depend on DetectorDescription/Core.

PR validation:

There is no code change - just move. The usual workflows should show no difference.

if this PR is a backport please specify the original PR:

Before submitting your pull requests, make sure you followed this checklist:

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26901/9944

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ianna (Ianna Osborne) for master.

It involves the following packages:

SimG4Core/Application
SimG4Core/Geometry
SimG4Core/Physics

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@ianna
Copy link
Contributor Author

ianna commented May 23, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 23, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/450/console Started: 2019/05/23 15:47

@cmsbuild
Copy link
Contributor

-1

Tested at: 62a6e47

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d91875/450/summary.html

I found follow errors while testing this PR

Failed tests: Build

  • Build:

I found compilation error when building:

Decay3Body.cc:(.text+0x724): undefined reference to `ROOT::Math::gv_detail::convert(ROOT::Math::EulerAngles const&, ROOT::Math::Rotation3D&)'
Decay3Body.cc:(.text+0x9cb): undefined reference to `ROOT::Math::Boost::SetComponents(double, double, double)'
Decay3Body.cc:(.text+0xac2): undefined reference to `ROOT::Math::Boost::operator()(ROOT::Math::LorentzVector > const&) const'
Decay3Body.cc:(.text+0xada): undefined reference to `ROOT::Math::Boost::operator()(ROOT::Math::LorentzVector > const&) const'
Decay3Body.cc:(.text+0xaf2): undefined reference to `ROOT::Math::Boost::operator()(ROOT::Math::LorentzVector > const&) const'
collect2: error: ld returned 1 exit status
gmake: *** [tmp/slc7_amd64_gcc700/src/SimG4Core/CustomPhysics/src/SimG4CoreCustomPhysics/libSimG4CoreCustomPhysics.so] Error 1
Leaving library rule at SimG4Core/CustomPhysics
Entering library rule at src/SimG4Core/CustomPhysics/plugins
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-05-22-2300/src/SimG4Core/CustomPhysics/plugins/RHStopTracer.cc 
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-05-22-2300/src/SimG4Core/CustomPhysics/plugins/module.cc 


@cmsbuild
Copy link
Contributor

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26901/9945

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

Pull request #26901 was updated. @cmsbuild, @civanch, @mdhildreth can you please check and sign again.

@ianna
Copy link
Contributor Author

ianna commented May 23, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 23, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/451/console Started: 2019/05/23 16:19

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d91875/451/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3206856
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3206520
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@civanch
Copy link
Contributor

civanch commented May 23, 2019

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 3405700 into cms-sw:master May 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants