New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SimG4: DD Direct Dependency Cleanup #26901
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26901/9944
|
A new Pull Request was created by @ianna (Ianna Osborne) for master. It involves the following packages: SimG4Core/Application @cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
-1 Tested at: 62a6e47 You can see the results of the tests here: I found follow errors while testing this PR Failed tests: Build
I found compilation error when building: Decay3Body.cc:(.text+0x724): undefined reference to `ROOT::Math::gv_detail::convert(ROOT::Math::EulerAngles const&, ROOT::Math::Rotation3D&)' Decay3Body.cc:(.text+0x9cb): undefined reference to `ROOT::Math::Boost::SetComponents(double, double, double)' Decay3Body.cc:(.text+0xac2): undefined reference to `ROOT::Math::Boost::operator()(ROOT::Math::LorentzVector > const&) const' Decay3Body.cc:(.text+0xada): undefined reference to `ROOT::Math::Boost::operator()(ROOT::Math::LorentzVector > const&) const' Decay3Body.cc:(.text+0xaf2): undefined reference to `ROOT::Math::Boost::operator()(ROOT::Math::LorentzVector > const&) const' collect2: error: ld returned 1 exit status gmake: *** [tmp/slc7_amd64_gcc700/src/SimG4Core/CustomPhysics/src/SimG4CoreCustomPhysics/libSimG4CoreCustomPhysics.so] Error 1 Leaving library rule at SimG4Core/CustomPhysics Entering library rule at src/SimG4Core/CustomPhysics/plugins >> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-05-22-2300/src/SimG4Core/CustomPhysics/plugins/RHStopTracer.cc >> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_0_X_2019-05-22-2300/src/SimG4Core/CustomPhysics/plugins/module.cc |
Comparison not run due to Build errors (RelVals and Igprof tests were also skipped) |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26901/9945
|
Pull request #26901 was updated. @cmsbuild, @civanch, @mdhildreth can you please check and sign again. |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
DDG4ProductionCuts
class fromSimG4Core/Physics
package toSimG4Core/Geometry
package to avoid direct dependency of the first onDetectorDescription/Core
. Only the latter should depend onDetectorDescription/Core
.PR validation:
There is no code change - just move. The usual workflows should show no difference.
if this PR is a backport please specify the original PR:
Before submitting your pull requests, make sure you followed this checklist: