New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address warnings raised from L1T DQM for UL reco #26937
Address warnings raised from L1T DQM for UL reco #26937
Conversation
A new Pull Request was created by @benkrikler for CMSSW_10_6_X. It involves the following packages: DQM/L1TMonitor @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @rekovic, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
@benkrikler can you forwardport this to CMSSW_11_X_Y too? |
@benkrikler before considering this PR we need to have master counterpart integrated |
…6-2300 Forward-port #26937: Remove warnings from L1T DQM
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Adds small fixes to prevent warnings from L1 DQM for the UL reco. Namely:
goodPFJetsForL1T
EDFilter, which appears in an EndJob.l1tStage2uGTTiming
from the sequence since it doesn't have Era-dependent configuration causing several warnings.PR validation:
I have confirmed that the reported warnings are no longer appearing, and the output DQM files seem as I'd expect.