Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address warnings raised from L1T DQM for UL reco #26937

Merged

Conversation

benkrikler
Copy link
Contributor

PR description:

Adds small fixes to prevent warnings from L1 DQM for the UL reco. Namely:

  • Tell CMSSW not to check the goodPFJetsForL1T EDFilter, which appears in an EndJob.
  • Remove l1tStage2uGTTiming from the sequence since it doesn't have Era-dependent configuration causing several warnings.

PR validation:

I have confirmed that the reported warnings are no longer appearing, and the output DQM files seem as I'd expect.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @benkrikler for CMSSW_10_6_X.

It involves the following packages:

DQM/L1TMonitor
DQMOffline/L1Trigger

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @rekovic, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@kreczko, @thomreis, @rociovilar this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 24, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/504/console Started: 2019/05/24 18:51

@benkrikler benkrikler changed the title Address warnings raised from L1 DQM for UL reco Address warnings raised from L1T DQM for UL reco May 24, 2019
@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1a5ca1/504/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3211316
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3210980
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -2186.629 KiB( 32 files compared)
  • DQMHistoSizes: changed ( 25202.0,... ): -143.699 KiB L1T/L1TStage2uGT
  • DQMHistoSizes: changed ( 158.0,... ): -145.996 KiB L1T/L1TStage2uGT
  • DQMHistoSizes: changed ( 11624.0,... ): -147.309 KiB L1T/L1TStage2uGT
  • DQMHistoSizes: changed ( 136.788 ): -144.520 KiB L1T/L1TStage2uGT
  • DQMHistoSizes: changed ( 10224.0,... ): -145.668 KiB L1T/L1TStage2uGT
  • DQMHistoSizes: changed ( 136.731 ): -146.784 KiB L1T/L1TStage2uGT
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@jfernan2
Copy link
Contributor

+1

@jfernan2
Copy link
Contributor

@benkrikler can you forwardport this to CMSSW_11_X_Y too?

@fabiocos
Copy link
Contributor

@benkrikler before considering this PR we need to have master counterpart integrated

cmsbuild added a commit that referenced this pull request Jun 3, 2019
…6-2300

Forward-port #26937: Remove warnings from L1T DQM
@rekovic
Copy link
Contributor

rekovic commented Jun 6, 2019

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2019

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Jun 6, 2019

+1

@cmsbuild cmsbuild merged commit 5e248a9 into cms-sw:CMSSW_10_6_X Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants