Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Running code-format for alca-l1 #26948

Merged
merged 1 commit into from May 30, 2019
Merged

Running code-format for alca-l1 #26948

merged 1 commit into from May 30, 2019

Conversation

cmsbuild
Copy link
Contributor

Applying code-format for CMSSW category alca,l1.
See the build logs here https://cmssdt.cern.ch/jenkins/job/GitHub-refactor-cmssw-module/282//console

cms-bot has successfully run the following:

  • scram build code-checks-all
  • scram build code-format-all
  • scram build

@cmsbuild
Copy link
Contributor Author

please test

@cmsbuild cmsbuild added this to the CMSSW_11_0_X milestone May 27, 2019
@cmsbuild
Copy link
Contributor Author

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor Author

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26948/9996

  • This PR adds an extra 8KB to repository

@cmsbuild
Copy link
Contributor Author

cmsbuild commented May 27, 2019 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/524/console Started: 2019/05/27 06:03

@cmsbuild
Copy link
Contributor Author

A new Pull Request was created by @cmsbuild for master.

It involves the following packages:

CalibCalorimetry/CaloTPG
CalibCalorimetry/EcalTPGTools
CalibCalorimetry/HcalTPGAlgos
CalibCalorimetry/HcalTPGEventSetup
CalibCalorimetry/HcalTPGIO

@christopheralanwest, @tocheng, @cmsbuild, @rekovic, @franzoni, @tlampen, @pohsun can you please review it and eventually sign? Thanks.
@mmusich, @tocheng, @argiro this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor Author

+1
Tested at: 7e23616
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b5d1e0/524/summary.html

@cmsbuild
Copy link
Contributor Author

Comparison job queued.

@cmsbuild
Copy link
Contributor Author

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b5d1e0/524/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3209232
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3208897
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@christopheralanwest
Copy link
Contributor

+1

fabiocos
fabiocos reviewed May 30, 2019
View reviewed changes
CalibCalorimetry/HcalTPGAlgos/src/HcaluLUTTPGCoder.cc
nonlinearityCorrection = corr.getRecoCorrectionFactor(effectivePixelsFired);
}
}
if (allLinear_)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smuzaffar the following splitting does not look nice, but I am afraid there not much that can be done in this case

@fabiocos
Copy link
Contributor

@rekovic apart for some formatting that looks a bit odd (but according to the rules) everything looks ok to me, I will move forward with the integration. In case please check

@fabiocos
Copy link
Contributor

+1

@fabiocos
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit afd617e into master May 30, 2019
@makortel makortel mentioned this pull request May 30, 2019
Merged
@smuzaffar smuzaffar deleted the code-format-alca-l1-6dc590 branch May 31, 2019 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabiocos fabiocos fabiocos left review comments

Assignees
No one assigned
Labels
alca-approved code-checks-approved comparison-available l1-pending orp-approved pending-signatures tests-approved
Projects
None yet
Milestone
CMSSW_11_0_X
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cmsbuild @christopheralanwest @fabiocos