Run2-hcx206 Take care of Phase2 situations for HCAL

[bsunanda]

PR description:

Modification in CalibCalorimetry/HcalPlugins and HcalTopology due to no HE scenario

PR validation:

Used standard runTheMatrix.py with "limited"

if this PR is a backport please specify the original PR:

Not to be back ported

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26966/10016

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

CalibCalorimetry/CaloTPG
CalibCalorimetry/HcalPlugins
Geometry/CaloTopology

@civanch, @Dr15Jones, @cvuosalo, @christopheralanwest, @ianna, @mdhildreth, @cmsbuild, @rekovic, @franzoni, @tocheng, @tlampen, @pohsun can you please review it and eventually sign? Thanks.
@mmusich, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/546/console Started: 2019/05/27 22:35

[cmsbuild]

+1
Tested at: b1c99e2
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8cbb31/546/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8cbb31/546/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3209232
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3208897
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[ianna]

+1

[srimanob]

Hi @bsunanda
Do we need a backport of this for 10_6 for L1T production campaign?

[bsunanda]

@srimanob As I mentioned in the meeting this need not be back ported because this is not affecting the workflows as yet

[cmsbuild]

+1
Tested at: 3879efc
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8cbb31/689/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8cbb31/689/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3210678
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3210342
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[christopheralanwest]

+1

[fabiocos]

@cvuosalo @ianna could you please have a look? I will consider the previous signature by @rekovic as valid

[cvuosalo]

+1

[rekovic]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1

[rekovic]

@bsunanda

@srimanob As I mentioned in the meeting this need not be back ported because this is not affecting the workflows as yet

Sorry I missed this discussion, so I am wondering about a few things.
Does it mean that our current Phase2 model does not include yet these "HCAL situations" as you called them, and that is why the Phase2 MC production does not depend on this PR? Can you please elaborate on this. Thanks.

[bsunanda]

@rekovic @srimanob Rethinking about it - may be worthwhile to backport this to 10_6. Also I am not sure if CaloTower code is retuned for Phase2 scenario. I shall take a look there

[rekovic]

@bsunanda
There are a few new Phase2 GEN-SIM-DIGI-RAW samples with CMSSW_10_6_0_patch2 release that just came out (Ele/Pho/Pi0/Pi guns). Can this be checked on these samples ?