Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

From NPozzobon : Fix to prevent crashes of the TT code at high PU #2698

Merged
merged 1 commit into from Mar 3, 2014

Conversation

boudoul
Copy link
Contributor

@boudoul boudoul commented Mar 3, 2014

code from @pozzobon
Replacing the PR #2692 (this PR #2692 should be closed)

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2014

A new Pull Request was created by @boudoul (boudoul) for CMSSW_6_2_X_SLHC.

From NPozzobon : Fix to prevent crashes of the TT code at high PU

It involves the following packages:

L1Trigger/TrackTrigger
SimTracker/TrackTriggerAssociation

@civanch, @nclopezo, @mdhildreth, @cmsbuild, @Degano, @mulhearn can you please review it and eventually sign? Thanks.
@cerati, @GiacomoSguazzoni, @rovere this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@andersonjacob, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mark-grimes
Copy link

merge

All tests pass other than known errors, so merging. Doesn't fix test 12800 (Extended2023TTI) though, was it supposed to? Test 12800 fails in step 2 with the following known errors.
Lots of this warning beforehand:

A L E R T! Side-Disk-Ring-Module already present!

Then fails with:

----- Begin Fatal Exception 03-Mar-2014 20:48:55 CET-----------------------
An exception of category 'StackedTrackerGeometryBuilder' occurred while
   [0] Processing run: 1
   [1] Running path 'L1TrackTrigger_step'
   [2] Calling beginRun for module TTClusterBuilder_PixelDigi_/'TTClustersFromPixelDigis'
   [3] Using EventSetup component StackedTrackerGeometryESModule/'' to make data StackedTrackerGeometry/'' in record StackedTrackerGeometryRecord
Exception Message:
There should be more Stacks in PXF disk 5, 0 Stacks were found and there should be 56
----- End Fatal Exception -------------------------------------------------

cmsbuild added a commit that referenced this pull request Mar 3, 2014
From NPozzobon : Fix to prevent crashes of the TT code at high PU
@cmsbuild cmsbuild merged commit 41aa546 into cms-sw:CMSSW_6_2_X_SLHC Mar 3, 2014
@boudoul
Copy link
Contributor Author

boudoul commented Mar 3, 2014

hi Mark
it was not supposed to fix the TTi scenario, i'm working on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants