TkAl All in One tool: don't import crabWrapper

[hroskes]

PR description:

Basically: don't mess with the environment. This caused 10+ messages like

sh: module: line 1: syntax error: unexpected end of file
sh: error importing function definition for `BASH_FUNC_module'

every time we ran the code.

On slc7 this was a more serious issue, because these lines were added to the output of the call to dasgoclient and causing it not to parse because it wasn't a valid json string.

PR validation:

Certain segments of validateAlignments won't work anymore because they're missing this import, but we don't use the configuration options that lead to those sections. Gregor Mittag tried to implement crab a long time ago but it never worked properly. I am not deleting crabWrapper and associated functionality from validateAlignments.py yet in case this conflicts with the condor migration, but if it doesn't, as far as I'm concerned someone can go ahead and delete it.

@adewit @connorpa @mmusich

if this PR is a backport please specify the original PR:

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26999/10055

• This PR adds an extra 24KB to repository

[cmsbuild]

A new Pull Request was created by @hroskes (Heshy Roskes) for master.

It involves the following packages:

Alignment/OfflineValidation

@christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @pohsun can you please review it and eventually sign? Thanks.
@mschrode, @mmusich, @adewit, @tocheng, @tlampen this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[christopheralanwest]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/599/console Started: 2019/05/30 02:33

[cmsbuild]

+1
Tested at: 2905450
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f20b5a/599/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f20b5a/599/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3210728
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3210392
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[christopheralanwest]

@adewit @connorpa @mmusich AlCa cannot review this PR in any sensible way. Whether or not it should be merged depends more on whether the subsystem experts want the change. AlCa will sign off if you confirm that the change is indeed desired.

[adewit]

I'm assuming that @hroskes verified that all the parts of validateAlignments that we actually use still work without this, so fine for me from that point of view. Just to be absolutely sure I'd like @henriettepetersen and @DaveBrun94 to confirm that this import is not used in any way in the HTCondor setup they're working on (I don't think it is, but better safe than sorry ;-) )

[hroskes]

Yes, the only places where this import is used are sections of the code that only happens if you put jobmode = crab or if add --status on the command line, which is also only supposed to be used to check crab jobs. I didn't want to create conflicts, but Henriette and David can go ahead and delete those lines.

[christopheralanwest]

@henriettepetersen @DaveBrun94 There is a request from @adewit that you confirm this import is not used in any way in the HTCondor setup you are working on.

[DaveBrun94]

@adewit We can confirm that this import is not used in the HTCondor setup

[christopheralanwest]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1