New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fireworks : Remove unused code in FWTauProxyBuilderBase #27001
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code-checks are being triggered in jenkins. |
This change is related to #26913 |
+1 |
cmsbuild
added
fully-signed
visualization-approved
and removed
pending-signatures
visualization-pending
labels
May 29, 2019
4 tasks
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27001/10058
|
The tests are being triggered in jenkins. |
Comparison not run due to Fireworks only changes in PR (RelVals and Igprof tests were also skipped) |
cmsbuild
added
comparison-notrun
tests-approved
and removed
comparison-pending
tests-started
labels
May 29, 2019
+1 |
This was referenced May 30, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unnecessary check a TubeSegement range in the RhoPhi projected view in FWTauProxyBuilderBase.