Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fireworks : Remove unused code in FWTauProxyBuilderBase #27001

Merged
merged 1 commit into from May 30, 2019

Conversation

alja
Copy link
Contributor

@alja alja commented May 29, 2019

Remove unnecessary check a TubeSegement range in the RhoPhi projected view in FWTauProxyBuilderBase.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@alja
Copy link
Contributor Author

alja commented May 29, 2019

This change is related to #26913

@alja
Copy link
Contributor Author

alja commented May 29, 2019

+1

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27001/10058

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented May 29, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/594/console Started: 2019/05/29 20:47

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @alja (Alja Mrak-Tadel) for master.

It involves the following packages:

Fireworks/Calo

@cmsbuild can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison not run due to Fireworks only changes in PR (RelVals and Igprof tests were also skipped)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 52cc8d8 into cms-sw:master May 30, 2019
@fabiocos
Copy link
Contributor

@alja this PR is unfortunately conflicting with #26919 that was left pending. Do you have issues with that? I will revert this one to get before integrated #26919 , then come back to this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants