Modernized ES modules in TrackingTools/TrackFitters #27003
Conversation
In addition to consumes, switched to using ESGetToken
In addition, switched to using ESGetToken.
In addition, switched to using ESGetToken.
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27003/10062
|
|
please test |
|
The tests are being triggered in jenkins. |
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: TrackingTools/TrackFitters @perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
part of #26748 |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
mixing massive code formats with actual code changes makes it impossible to review |
|
@VinInn the format was done on a separate commit. It is possible to add comments to individual commits which would allow you to see just the code changes. |
|
the commits are separated |
|
On 5/30/19 5:37 AM, Vincenzo Innocente wrote:
mixing massive code formats with actual code changes makes it impossible
to review
the commits are separated
so
https://github.com/cms-sw/cmssw/pull/27003/files/c4ef96fe433d92406c4d5668b5d12833c130d4be..8475148a422fe4b9d3340c9ea82fc89df6b47f20
is the easy to read part and allows for comments
|
|
+1
|
cmsbuild
added
fully-signed
reconstruction-approved
and removed
pending-signatures
reconstruction-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
| theErrorRescaling(errorRescaling), | ||
| minHits_(minHits), | ||
| theGeometry( | ||
| nullptr) { // to be fixed. Why this first constructor is needed? who is using it? Can it be removed? |
| if (it->recHitR().isValid()) | ||
| break; | ||
| tmpTraj.push(std::move(*it), | ||
| smoothed.chiSquared()); //push the first valid measurement and set the same global chi2 |
|
+1 |
PR description:
PR validation:
Code compiles