New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scenario 2021 with: Detailed Cavern, MB4 Neutron Shields (YB+2, YB-2,… #27004
Conversation
… S 4 S13) and overlaps, inside the Muon System, fixed
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27004/10064
|
A new Pull Request was created by @slomeo (Sergio Lo Meo) for master. It involves the following packages: Geometry/CMSCommonData @civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
@@ -7,20 +7,23 @@ | |||
'Geometry/CMSCommonData/data/materials.xml', | |||
'Geometry/CMSCommonData/data/rotations.xml', | |||
'Geometry/CMSCommonData/data/extend/v2/cmsextent.xml', | |||
'Geometry/CMSCommonData/data/cms/2019/v2/cms.xml', | |||
# 'Geometry/CMSCommonData/data/cms/2019/v2/cms.xml', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please delete all commented-out lines in this file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please delete all commented-out lines in this file
done
@fabiocos I added a line to cms.xml. Tks! |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27004/10226
|
Pull request #27004 was updated. @civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please check and sign again. |
Comparison is ready Comparison Summary:
|
+1 |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@kpedro88 any further comment? |
+upgrade |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
@ianna @fabiocos
Scenario 2021 with: Detailed Cavern, MB4Shield and Muon overlaps fixed
PR description:
Scenario 2021 with: Detailed Cavern, MB4 Neutron Shields (YB+2, YB-2, S4 S13) and Overlaps, inside the Muon System, fixed
PR validation:
Test ok with cmsShow (there are 188 overlaps in CALO, TRACKER, FORWARDSHIELD)
if this PR is a backport please specify the original PR:
Before submitting your pull requests, make sure you followed this checklist: