Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scenario 2021 with: Detailed Cavern, MB4 Neutron Shields (YB+2, YB-2,… #27004

Merged
merged 3 commits into from Jun 6, 2019

Conversation

slomeo
Copy link
Contributor

@slomeo slomeo commented May 30, 2019

overlaps
@ianna @fabiocos
Scenario 2021 with: Detailed Cavern, MB4Shield and Muon overlaps fixed

PR description:

Scenario 2021 with: Detailed Cavern, MB4 Neutron Shields (YB+2, YB-2, S4 S13) and Overlaps, inside the Muon System, fixed

PR validation:

Test ok with cmsShow (there are 188 overlaps in CALO, TRACKER, FORWARDSHIELD)

if this PR is a backport please specify the original PR:

Before submitting your pull requests, make sure you followed this checklist:

… S 4 S13) and overlaps, inside the Muon System, fixed
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27004/10064

  • This PR adds an extra 36KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @slomeo (Sergio Lo Meo) for master.

It involves the following packages:

Geometry/CMSCommonData
Geometry/MuonCommonData

@civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@ptcox this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@kpedro88
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 30, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/615/console Started: 2019/05/30 19:01

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-139826/615/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3210678
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3210343
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@cvuosalo
Copy link
Contributor

cvuosalo commented Jun 3, 2019

+1

@@ -7,20 +7,23 @@
'Geometry/CMSCommonData/data/materials.xml',
'Geometry/CMSCommonData/data/rotations.xml',
'Geometry/CMSCommonData/data/extend/v2/cmsextent.xml',
'Geometry/CMSCommonData/data/cms/2019/v2/cms.xml',
# 'Geometry/CMSCommonData/data/cms/2019/v2/cms.xml',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please delete all commented-out lines in this file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please delete all commented-out lines in this file

done

@slomeo
Copy link
Contributor Author

slomeo commented Jun 5, 2019

@fabiocos I added a line to cms.xml. Tks!

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27004/10226

  • This PR adds an extra 40KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2019

Pull request #27004 was updated. @civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-139826/758/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3210222
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3209886
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@cvuosalo
Copy link
Contributor

cvuosalo commented Jun 5, 2019

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/787/console Started: 2019/06/05 17:55

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-139826/787/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3210222
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3209887
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@fabiocos
Copy link
Contributor

fabiocos commented Jun 6, 2019

@kpedro88 any further comment?

@kpedro88
Copy link
Contributor

kpedro88 commented Jun 6, 2019

+upgrade

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Jun 6, 2019

+1

@cmsbuild cmsbuild merged commit acc776f into cms-sw:master Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants