Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of HTXS filter to 102X #27036

Merged
merged 1 commit into from Jun 6, 2019

Conversation

janekbechtel
Copy link
Contributor

PR description:

Will enable filtering events during GEN-SIM production based on the HTXS classification output. This will be used in production of MC extension events for the legacy SM H->tautau analysis.

if this PR is a backport please specify the original PR:

Backport of #26891

Before submitting your pull requests, make sure you followed this checklist:

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @janekbechtel (Janek Bechtel) for CMSSW_10_2_X.

It involves the following packages:

GeneratorInterface/GenFilters

@alberto-sanchez, @cmsbuild, @qliphy, @agrohsje, @efeyazgan can you please review it and eventually sign? Thanks.
@alberto-sanchez, @agrohsje, @mkirsano this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@efeyazgan
Copy link
Contributor

Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 31, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/656/console Started: 2019/05/31 16:43

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e5d5cb/656/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 3007468
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3007277
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 129 log files, 14 edm output root files, 31 DQM output files

@janekbechtel
Copy link
Contributor Author

Can someone check this PR? It will be needed as soon as possible for a MC production campaign

@fabiocos
Copy link
Contributor

fabiocos commented Jun 5, 2019

@efeyazgan @qliphy apparently this is more urgent than discussed yesterday...

@efeyazgan
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2019

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Jun 6, 2019

+1

@cmsbuild cmsbuild merged commit 8b7ecb4 into cms-sw:CMSSW_10_2_X Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants