Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New fragments with extended eta range /runThematrix updtaed accordingly #2706

Merged
merged 2 commits into from Mar 4, 2014

Conversation

boudoul
Copy link
Contributor

@boudoul boudoul commented Mar 3, 2014

No description provided.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2014

A new Pull Request was created by @boudoul (boudoul) for CMSSW_6_2_X_SLHC.

New fragments with extended eta range /runThematrix updtaed accordingly

It involves the following packages:

Configuration/Generator
Configuration/PyReleaseValidation

@vciulli, @nclopezo, @vlimant, @cmsbuild, @franzoni, @bendavid, @Degano, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@andersonjacob, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@boudoul
Copy link
Contributor Author

boudoul commented Mar 3, 2014

Hi Mark , you can take abit later this PR at your convenance, as it might change your usual WF numbering : I have added new WFs so the numbering will be different after the merge.

@@ -1245,7 +1245,7 @@ def genvalid(fragment,d,suffix='all',fi=''):
if upgradeCustoms[k]!=None : upgradeStepDict['HARVESTFast'][k]['--customise']=upgradeCustoms[k]


upgradeFragments=['FourMuPt_1_200_cfi','SingleElectronPt10_cfi',
upgradeFragments=['FourMuPt_1_200_cfi','TenMuE_0_200_cfi','SingleElectronPt10_cfi',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does TenMuE_0_200_cfi need to be the second entry? It could be moved to the end and the numbering for the current tests won't change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect for me!

@mark-grimes
Copy link

If the numbering does need to change, we might as well do it sooner rather later. We could move all the new fragments to after the current ones and the numbering won't change though.

@bendavid
Copy link
Contributor

bendavid commented Mar 4, 2014

+1

@mark-grimes
Copy link

merge

Tested along with #2708 and #2711. Tests 10000, 10200, 10400, 11200, 11400, 11600, 11800, 12000 and 13000 pass all steps. Tests 12200, 12400, 12600, 12800, 13200 and 13400 fail in step 2 with known errors. Checked and the test numbering is indeed unchanged.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2014

Pull request #2706 was updated. @vciulli, @nclopezo, @vlimant, @cmsbuild, @franzoni, @bendavid, @Degano, @davidlange6 can you please check and sign again.

cmsbuild added a commit that referenced this pull request Mar 4, 2014
New fragments with extended eta range /runThematrix updtaed accordingly
@cmsbuild cmsbuild merged commit 4eb513a into cms-sw:CMSSW_6_2_X_SLHC Mar 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants