Running code-format for reconstruction #27074

cmsbuild · 2019-06-03T03:48:18Z

Applying code-format for CMSSW category reconstruction.
See the build logs here https://cmssdt.cern.ch/jenkins/job/GitHub-refactor-cmssw-module/349//console

cms-bot has successfully run the following:

scram build code-checks-all
scram build code-format-all
scram build

cmsbuild · 2019-06-03T03:48:19Z

please test

cmsbuild · 2019-06-03T03:48:58Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-06-03T03:54:32Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27074/10159

This PR adds an extra 8KB to repository

cmsbuild · 2019-06-03T03:55:04Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/710/console Started: 2019/06/03 06:19

cmsbuild · 2019-06-03T03:55:06Z

A new Pull Request was created by @cmsbuild for master.

It involves the following packages:

DataFormats/ProtonReco
DataFormats/TauReco
DataFormats/TrajectorySeed
EventFilter/SiStripRawToDigi
RecoParticleFlow/PFTracking
RecoTracker/TkNavigation
RecoTracker/TransientTrackingRecHit
TrackingTools/TrackRefitter

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@felicepantaleo, @abbiendi, @Martin-Grunewald, @seemasharmafnal, @mmarionncern, @battibass, @makortel, @jhgoh, @lgray, @HuguesBrun, @trocino, @GiacomoSguazzoni, @rovere, @VinInn, @bellan, @hatakeyamak, @mschrode, @ebrondol, @dgulhan, @calderona, @bachtis, @cbernet, @gpetruc, @folguera this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2019-06-03T07:45:54Z

+1
Tested at: 7622cf3
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d70054/710/summary.html

cmsbuild · 2019-06-03T07:45:58Z

Comparison job queued.

cmsbuild · 2019-06-03T10:17:18Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d70054/710/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 33
DQMHistoTests: Total histograms compared: 3210678
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3210343
DQMHistoTests: Total skipped: 334
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
Checked 137 log files, 14 edm output root files, 33 DQM output files

slava77 · 2019-06-05T20:10:43Z

DataFormats/TauReco/interface/PFTau.h

+    float hcalTotOverPLead() const;  // total Hcal Cluster E / leadPFChargedHadron P
+    float hcalMaxOverPLead() const;  // max. Hcal Cluster E / leadPFChargedHadron P
+    float hcal3x3OverPLead()
+        const;  // Hcal Cluster E in R<0.184 around Ecal impact point of leading track / leadPFChargedHadron P


comment line issue

slava77 · 2019-06-05T20:11:29Z

DataFormats/TauReco/interface/PFTauDecayMode.h

+  class PFTauDecayMode : public CompositeCandidate {
+  public:
+    const static unsigned char maxNumberOfPiZeroCandidatesAllowed =
+        4;  //to help with indexing.  changing this value necissitates changing the enum below


comment line issue

slava77 · 2019-06-05T20:17:42Z

EventFilter/SiStripRawToDigi/test/plugins/SiStripDigiAnalyzer.h

+  /** Default constructor. */
+  SiStripTrivialDigiAnalysis()
+      : events_(0), feds_(0), channels_(0), strips_(0), digis_(0), size_(1024), pos_(size_ + 1, 0), adc_(size_ + 1, 0) {
+    ;


can be removed

slava77 · 2019-06-05T20:19:41Z

RecoParticleFlow/PFTracking/plugins/GoodSeedProducer.cc

+
+        float oPTOB =
+            1.f /
+            std::sqrt(Tk[i].innerMomentum().mag2());  // FIXME the original code was buggy should be outerMomentum...


here is a bad 3-line break

slava77 · 2019-06-05T20:27:22Z

RecoParticleFlow/PFTracking/test/PreIdAnalyzer.cc

-  dbe->save("PreId.root"); 
-  ;}
+  dbe->save("PreId.root");
+  ;


another noop

slava77 · 2019-06-05T20:30:56Z

RecoTracker/TkNavigation/test/NavigationSchoolAnalyzer.cc

  const std::vector<const GeomDet*>& bComponents = dl->basicComponents();

-  if (bComponents.empty()){/* t'es pas dans la merde */;return;}
+  if (bComponents.empty()) { /* t'es pas dans la merde */
+    ;


a noop and perhaps an expletive cleanup

slava77 · 2019-06-05T20:36:06Z

+1

for #27074 7622cf3

technical
jenkins tests pass

#27074 (review) can be followed up in another PR

cmsbuild · 2019-06-05T20:36:40Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

fabiocos · 2019-06-06T07:49:42Z

+1

cmsbuild added 2 commits June 3, 2019 05:44

Clang-tidy

4dac4d9

Clang-Format

7622cf3

cmsbuild added this to the CMSSW_11_0_X milestone Jun 3, 2019

cmsbuild added code-checks-pending comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Jun 3, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 3, 2019

cmsbuild added tests-started and removed tests-pending labels Jun 3, 2019

cmsbuild added tests-approved and removed tests-started labels Jun 3, 2019

cmsbuild added comparison-available and removed comparison-pending labels Jun 3, 2019

slava77 reviewed Jun 5, 2019

View reviewed changes

cmsbuild added fully-signed and removed pending-signatures reconstruction-pending labels Jun 5, 2019

cmsbuild added the reconstruction-approved label Jun 5, 2019

cmsbuild added orp-approved and removed orp-pending labels Jun 6, 2019

cmsbuild merged commit f866233 into master Jun 6, 2019

This was referenced Jun 6, 2019

improvements to the HGCHEback digitizer and implementation of a end-of-life scenario for the HGC scintillator section #26811

Merged

Improvements to PSet Entry implementation #27127

Merged

Enable tau validation for phase 2 #27120

Merged

smuzaffar deleted the code-format-reconstruction-244a0f branch June 7, 2019 06:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Running code-format for reconstruction #27074

Running code-format for reconstruction #27074

cmsbuild commented Jun 3, 2019

cmsbuild commented Jun 3, 2019

cmsbuild commented Jun 3, 2019

cmsbuild commented Jun 3, 2019

cmsbuild commented Jun 3, 2019 •

edited

cmsbuild commented Jun 3, 2019

cmsbuild commented Jun 3, 2019

cmsbuild commented Jun 3, 2019

cmsbuild commented Jun 3, 2019

slava77 Jun 5, 2019

slava77 Jun 5, 2019

slava77 Jun 5, 2019

slava77 Jun 5, 2019

slava77 Jun 5, 2019

slava77 Jun 5, 2019

slava77 commented Jun 5, 2019

cmsbuild commented Jun 5, 2019

fabiocos commented Jun 6, 2019

Running code-format for reconstruction #27074

Running code-format for reconstruction #27074

Conversation

cmsbuild commented Jun 3, 2019

cmsbuild commented Jun 3, 2019

cmsbuild commented Jun 3, 2019

cmsbuild commented Jun 3, 2019

cmsbuild commented Jun 3, 2019 • edited

cmsbuild commented Jun 3, 2019

cmsbuild commented Jun 3, 2019

cmsbuild commented Jun 3, 2019

cmsbuild commented Jun 3, 2019

slava77 Jun 5, 2019

Choose a reason for hiding this comment

slava77 Jun 5, 2019

Choose a reason for hiding this comment

slava77 Jun 5, 2019

Choose a reason for hiding this comment

slava77 Jun 5, 2019

Choose a reason for hiding this comment

slava77 Jun 5, 2019

Choose a reason for hiding this comment

slava77 Jun 5, 2019

Choose a reason for hiding this comment

slava77 commented Jun 5, 2019

cmsbuild commented Jun 5, 2019

fabiocos commented Jun 6, 2019

cmsbuild commented Jun 3, 2019 •

edited