Running code-format for reconstruction #27075

cmsbuild · 2019-06-03T03:51:54Z

Applying code-format for CMSSW category reconstruction.
See the build logs here https://cmssdt.cern.ch/jenkins/job/GitHub-refactor-cmssw-module/350//console

cms-bot has successfully run the following:

scram build code-checks-all
scram build code-format-all
scram build

cmsbuild · 2019-06-03T03:51:55Z

please test

cmsbuild · 2019-06-03T03:52:32Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-06-03T04:00:41Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27075/10161

This PR adds an extra 8KB to repository

cmsbuild · 2019-06-03T04:01:19Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/716/console Started: 2019/06/03 07:16

cmsbuild · 2019-06-03T04:01:21Z

A new Pull Request was created by @cmsbuild for master.

It involves the following packages:

DataFormats/EgammaTrackReco
EventFilter/DTRawToDigi
EventFilter/HcalRawToDigi
MagneticField/ParametrizedEngine
RecoBTag/MXNet
RecoBTag/PerformanceDB
RecoLocalCalo/HcalRecAlgos
RecoLocalCalo/HcalRecProducers
RecoMuon/GlobalMuonProducer

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@abbiendi, @argiro, @echapon, @battibass, @smoortga, @acaudron, @jhgoh, @HuguesBrun, @hqucms, @ferencek, @trocino, @HeinerTholen, @rociovilar, @rovere, @bellan, @Martin-Grunewald, @namapane, @calderona, @mverzett, @JyothsnaKomaragiri, @folguera, @mariadalfonso, @pvmulder, @bachtis this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2019-06-03T07:11:22Z

+1
Tested at: 6492b4d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4fbcd2/716/summary.html

cmsbuild · 2019-06-03T07:11:26Z

Comparison job queued.

cmsbuild · 2019-06-03T08:48:50Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4fbcd2/716/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 33
DQMHistoTests: Total histograms compared: 3210678
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3210343
DQMHistoTests: Total skipped: 334
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
Checked 137 log files, 14 edm output root files, 33 DQM output files

perrotta · 2019-06-04T15:20:30Z

EventFilter/HcalRawToDigi/interface/HcalLaserEventFilter2012.h

+  typedef std::vector<std::string> strVec;
+  typedef std::vector<std::string>::iterator strVecI;
+
+  std::vector<std::string>


Comments could be reshuffled to avoid this line splitting

perrotta · 2019-06-04T15:22:50Z

EventFilter/HcalRawToDigi/plugins/HcalLaserHBHEFilter2012.cc

-  double minFracDiffHBHELaser_;  // minimum difference in fractional occupancies between 'good' and 'bad' HBHE regions (i.e., regions whose RBXes receive laser signals and those whose RBXes see no laser) necessary to declare an event as a laser event.  In laser events, good fractional occupancy is generally near 1, while bad fractional occupancy is considerably less
-  edm::InputTag     digiLabel_;
-  edm::EDGetTokenT<HcalCalibDigiCollection>  tok_calib_;
+  std::string


same here and the lines below

perrotta · 2019-06-04T15:24:03Z

EventFilter/HcalRawToDigi/plugins/HcalLaserHBHEHFFilter2012.cc

-  std::vector <int> CalibTS_; // time slices used when integrating calib charges
+  bool filterHBHE_;  // Flag to activate laser filter for HBHE
+  int minCalibChannelsHBHELaser_;  // set minimum number of HBHE Calib events that causes an event to be considered a bad (i.e., HBHE laser) event
+  double


perrotta · 2019-06-04T15:30:46Z

MagneticField/ParametrizedEngine/src/BFit3D_data.h

+  //_______________________________________________________________________________
+  const double BFit3D::C0[360][4] = {  //Constant terms, shifted to left
+                                       //(since at B_nom = 0 all of them are equal to zero)
+      {2.02156144404716e+00, 3.51621670097246e+00, 3.81142532261878e+00, 4.01241090152589e+00},


Definitely the previous version was much more readable.
This is probably a god place where to forbid clang formatting.

perrotta · 2019-06-04T15:31:16Z

MagneticField/ParametrizedEngine/src/BFit3D_data.h

+      {1.34237684985945e-10, 2.53064579553359e-11, 1.50183540218717e-10, 3.71381437949006e-11},
+      {3.36871860756778e-10, 2.87290939807854e-10, 6.86524917689277e-10, 1.17431905499043e-09},
+      {3.66460831436455e-10, 3.66607928682510e-10, 4.46409858543281e-10, 6.58153206569430e-10},
+      {2.96805661632454e-10, -9.447074


(Even more) Definitely the previous version was much more readable.
This is probably a god place where to forbid clang formatting.

perrotta · 2019-06-04T15:31:52Z

MagneticField/ParametrizedEngine/src/BFit3D_data.h

+      {1.34237684985945e-10, 2.53064579553359e-11, 1.50183540218717e-10, 3.71381437949006e-11},
+      {3.36871860756778e-10, 2.87290939807854e-10, 6.86524917689277e-10, 1.17431905499043e-09},
+      {3.66460831436455e-10, 3.66607928682510e-10, 4.46409858543281e-10, 6.58153206569430e-10},
+      {2.96805661632454e-10, -9.447074


Definitely the previous version was much more readable.
This is probably a god place where to forbid clang formatting.

perrotta · 2019-06-04T15:58:27Z

@smuzaffar @fabiocos
You can consider this as signed by reco, but before merging in the IB I would like to check whether it is easier to fix things as in MagneticField/ParametrizedEngine/src/BFit3D_data.h (see comments above) directly here, or just merge this PR and revert it in a subsequent one: please let me know.

cmsbuild · 2019-06-05T06:51:14Z

Pull request #27075 was updated. @perrotta, @cmsbuild, @slava77 can you please check and sign again.

fabiocos · 2019-06-05T07:23:45Z

@smuzaffar @perrotta @slava77 we had a similar case yesterday, see https://github.com/cms-sw/cmssw/pull/27067/files/f667b1b79b88ee35a71999e20052446e8a4228dd#diff-cf19564532634461084a77f9f0fa38e7 , I played a bit with moving comments but did not help. So in case we could exclude also that table from formatting. In general I think that this kind of intiializations could be also stored in some data file, I guess it is simply more efficient to avoid too many file accesses during initialization...

perrotta · 2019-06-05T13:49:47Z

Are the code-format suggestions in #27075 (comment) that prevent the tests starting?
I think they can safely get applied, and then proceed with the tests

fabiocos · 2019-06-05T13:59:45Z

please test

cmsbuild · 2019-06-05T14:01:47Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/781/console Started: 2019/06/05 16:02

cmsbuild · 2019-06-05T16:29:29Z

+1
Tested at: 899c213
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4fbcd2/781/summary.html

cmsbuild · 2019-06-05T16:29:32Z

Comparison job queued.

cmsbuild · 2019-06-05T18:56:43Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4fbcd2/781/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 33
DQMHistoTests: Total histograms compared: 3210222
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3209887
DQMHistoTests: Total skipped: 334
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
Checked 137 log files, 14 edm output root files, 33 DQM output files

perrotta · 2019-06-05T21:48:35Z

+1

Technical
jenkins tests pass

cmsbuild · 2019-06-05T21:49:02Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

fabiocos · 2019-06-06T07:50:22Z

+1

Clang-Format

6492b4d

cmsbuild added this to the CMSSW_11_0_X milestone Jun 3, 2019

cmsbuild added code-checks-pending comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Jun 3, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 3, 2019

cmsbuild added tests-started and removed tests-pending labels Jun 3, 2019

cmsbuild added tests-approved and removed tests-started labels Jun 3, 2019

cmsbuild added comparison-available and removed comparison-pending labels Jun 3, 2019

perrotta reviewed Jun 4, 2019

View reviewed changes

smuzaffar added 2 commits June 5, 2019 08:29

turn off clang-format for selected region

048c870

reorder the comments to avoid ugly clang-formats

0bc0bfb

cmsbuild removed code-checks-approved comparison-available labels Jun 5, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 5, 2019

cmsbuild added tests-started and removed tests-pending labels Jun 5, 2019

cmsbuild added tests-approved and removed tests-started labels Jun 5, 2019

cmsbuild added comparison-available and removed comparison-pending labels Jun 5, 2019

cmsbuild added fully-signed reconstruction-approved and removed pending-signatures reconstruction-pending labels Jun 5, 2019

cmsbuild added orp-approved and removed orp-pending labels Jun 6, 2019

cmsbuild merged commit e5eec2d into master Jun 6, 2019

This was referenced Jun 6, 2019

improvements to the HGCHEback digitizer and implementation of a end-of-life scenario for the HGC scintillator section #26811

Merged

Improvements to PSet Entry implementation #27127

Merged

Enable tau validation for phase 2 #27120

Merged

smuzaffar deleted the code-format-reconstruction-3e6183 branch June 7, 2019 06:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Running code-format for reconstruction #27075

Running code-format for reconstruction #27075

cmsbuild commented Jun 3, 2019

cmsbuild commented Jun 3, 2019

cmsbuild commented Jun 3, 2019

cmsbuild commented Jun 3, 2019

cmsbuild commented Jun 3, 2019 •

edited

cmsbuild commented Jun 3, 2019

cmsbuild commented Jun 3, 2019

cmsbuild commented Jun 3, 2019

cmsbuild commented Jun 3, 2019

perrotta Jun 4, 2019

smuzaffar Jun 5, 2019

perrotta Jun 4, 2019

smuzaffar Jun 5, 2019

perrotta Jun 4, 2019

smuzaffar Jun 5, 2019

perrotta Jun 4, 2019

perrotta Jun 4, 2019

perrotta Jun 4, 2019

smuzaffar Jun 5, 2019

perrotta commented Jun 4, 2019

cmsbuild commented Jun 5, 2019

fabiocos commented Jun 5, 2019

perrotta commented Jun 5, 2019

fabiocos commented Jun 5, 2019

cmsbuild commented Jun 5, 2019 •

edited

cmsbuild commented Jun 5, 2019

cmsbuild commented Jun 5, 2019

cmsbuild commented Jun 5, 2019

perrotta commented Jun 5, 2019

cmsbuild commented Jun 5, 2019

fabiocos commented Jun 6, 2019

Running code-format for reconstruction #27075

Running code-format for reconstruction #27075

Conversation

cmsbuild commented Jun 3, 2019

cmsbuild commented Jun 3, 2019

cmsbuild commented Jun 3, 2019

cmsbuild commented Jun 3, 2019

cmsbuild commented Jun 3, 2019 • edited

cmsbuild commented Jun 3, 2019

cmsbuild commented Jun 3, 2019

cmsbuild commented Jun 3, 2019

cmsbuild commented Jun 3, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

perrotta commented Jun 4, 2019

cmsbuild commented Jun 5, 2019

fabiocos commented Jun 5, 2019

perrotta commented Jun 5, 2019

fabiocos commented Jun 5, 2019

cmsbuild commented Jun 5, 2019 • edited

cmsbuild commented Jun 5, 2019

cmsbuild commented Jun 5, 2019

cmsbuild commented Jun 5, 2019

perrotta commented Jun 5, 2019

cmsbuild commented Jun 5, 2019

fabiocos commented Jun 6, 2019

cmsbuild commented Jun 3, 2019 •

edited

cmsbuild commented Jun 5, 2019 •

edited