Update global tags to include new EGamma regression #27089

christopheralanwest · 2019-06-04T04:25:28Z

PR description:

This PR adds test GTs needed to test PR #26892 and should be merged simultaneously with that PR. I created a separate PR so that I could launch the PR tests myself now but the two PRs could be merged if that's more convenient. The naming of the GTs will be fixed with the autoCond update that finalizes the 2017 UL data and MC GTs. The diffs of the changed GTs with respect to the current autoCond GTs are below:

PR validation:

Tested with PR #26892 on workflow 27434.0.

if this PR is a backport please specify the original PR:

This PR will need to be backported to 10_6_X.

cmsbuild · 2019-06-04T04:26:02Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-06-04T04:31:35Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27089/10178

This PR adds an extra 12KB to repository

cmsbuild · 2019-06-04T04:32:08Z

A new Pull Request was created by @christopheralanwest for master.

It involves the following packages:

Configuration/AlCa

@christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @pohsun can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @mmusich, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

christopheralanwest · 2019-06-04T04:33:01Z

please test with #26892

cmsbuild · 2019-06-04T04:33:40Z

The tests are being triggered in jenkins.
Tested with other pull request(s) #26892
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/734/console Started: 2019/06/04 06:34

cmsbuild · 2019-06-04T06:22:12Z

-1

Tested at: 42bc42c

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cd0b11/734/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

RelVals:

When I ran the RelVals I found an error in the following workflows:
136.7611 step2

runTheMatrix-results/136.7611_RunJetHT2016E_reminiaod+RunJetHT2016E_reminiaod+REMINIAOD_data2016_HIPM+HARVESTDR2_REMINIAOD_data2016_HIPM/step2_RunJetHT2016E_reminiaod+RunJetHT2016E_reminiaod+REMINIAOD_data2016_HIPM+HARVESTDR2_REMINIAOD_data2016_HIPM.log

136.8311 step2

runTheMatrix-results/136.8311_RunJetHT2017F_reminiaod+RunJetHT2017F_reminiaod+REMINIAOD_data2017+HARVEST2017_REMINIAOD_data2017/step2_RunJetHT2017F_reminiaod+RunJetHT2017F_reminiaod+REMINIAOD_data2017+HARVEST2017_REMINIAOD_data2017.log

1325.7 step2

runTheMatrix-results/1325.7_TTbar_13_94Xv2NanoAODINPUT+TTbar_13_94Xv2NanoAODINPUT+NANOEDMMC2017_94XMiniAODv2+HARVESTNANOAODMC2017_94XMiniAODv2/step2_TTbar_13_94Xv2NanoAODINPUT+TTbar_13_94Xv2NanoAODINPUT+NANOEDMMC2017_94XMiniAODv2+HARVESTNANOAODMC2017_94XMiniAODv2.log

cmsbuild · 2019-06-04T06:22:18Z

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

cmsbuild · 2019-06-04T12:33:08Z

The tests are being triggered in jenkins.
Tested with other pull request(s) #26892
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/740/console Started: 2019/06/04 14:34

cmsbuild · 2019-06-04T15:28:30Z

+1
Tested at: 42bc42c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f30cb6/740/summary.html

cmsbuild · 2019-06-04T15:28:38Z

Comparison job queued.

cmsbuild · 2019-06-10T06:21:24Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cd0b11/853/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 8930 differences found in the comparisons
DQMHistoTests: Total files compared: 33
DQMHistoTests: Total histograms compared: 3215458
DQMHistoTests: Total failures: 1843
DQMHistoTests: Total nulls: 6
DQMHistoTests: Total successes: 3213275
DQMHistoTests: Total skipped: 334
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.024 KiB( 32 files compared)
DQMHistoSizes: changed ( 136.85 ): 0.016 KiB JetMET/SUSYDQM
DQMHistoSizes: changed ( 136.788 ): 0.008 KiB JetMET/SUSYDQM
Checked 137 log files, 14 edm output root files, 33 DQM output files

Sam-Harper · 2019-06-10T10:40:04Z

@Sam-Harper
please take a look at
#27089 (comment)

Additionally, I'd like to understand the recent discussion about deploying calibrations for different years. The recent era-based reorganization in #26892 was done assuming only 2017 gets consistently updated because only for 2017 there is a consistent set of GTs.
I notice that the data GT EGamma GBR payloads have only one IOV. Is there a plan to add per-year IOVs?

So our end goal is this:

a single data GT which does 2016, 2017, 2018.
separate MC tags for 2016, 2017, 2018

I have to admit, I wasnt aware of the the single data GT originally but fine, its merely a technical detail.

Now this simple picture is rather complicated by the fact that 2016, 2018 does not exist right now. And also you cant pre-prend iovs so at somepoint we'll need a new GT for data.

This plan was agreed in PPD coordination. Get the conditions ready for 2017, get that running and then get 2018, then 2016, there being little point in waiting another month to start 2017.

At this point, none of this is specific to e/gamma, and hopefully should not be news to anybody.

Now on to E/gamma. For the PF cluster and mustache SC, they can share the same code so they are simply a conditions update. There was some confusion and they were orignally applied for all tags. But that should be reverted now. They should be no different to any other conditions prep for 2017.

Now we get to the electron/photon regressions. These are not backwards compatible changes. This was made even more tedious by oversights in the original conf format which is just the payload of the GBRForest but not the meta data needed to interpret it, such as the response range and the variables used.

Therefore we are in the lovely situation where the payload is controlled by the GT but the meta data is in the release. This normally wouldn't be a huge issue except for the fact in this unique situation we're sending out the release before finishing the conditions.

In time, new conditions will be deployed for 2016, 2018 which will mean updating the release at that point in time as well. Its not as if the conditions they currently get are in any way right or correct btw. 2016/2018 are currently in an intermediate undefined and non-physics quality state. This is simply unavoidable and is a chicken and egg scenario (which I want to see if we can do something about in the future).

Also in time, I'll probably update the default conditions as well to the new ele/pho regressions. Its not as if the regression RunI or HION currently gets is in anyway tuned to it, however it should probably have the conditions matched to its PF rec-hit thresholds which as far as I can tell is the 2018 PF rec-hit thresholds tuned on an overly pessimistic ecal noise model.

cmsbuild · 2019-06-10T19:14:54Z

The tests are being triggered in jenkins.
Tested with other pull request(s) #26892
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/861/console Started: 2019/06/10 21:16

cmsbuild · 2019-06-10T21:37:40Z

+1
Tested at: a74a716
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f30cb6/861/summary.html

cmsbuild · 2019-06-10T21:37:46Z

Comparison job queued.

cmsbuild · 2019-06-10T23:42:33Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f30cb6/861/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 8982 differences found in the comparisons
DQMHistoTests: Total files compared: 33
DQMHistoTests: Total histograms compared: 3215458
DQMHistoTests: Total failures: 1843
DQMHistoTests: Total nulls: 6
DQMHistoTests: Total successes: 3213275
DQMHistoTests: Total skipped: 334
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.024 KiB( 32 files compared)
DQMHistoSizes: changed ( 136.788 ): 0.008 KiB JetMET/SUSYDQM
DQMHistoSizes: changed ( 136.85 ): 0.016 KiB JetMET/SUSYDQM
Checked 137 log files, 14 edm output root files, 33 DQM output files

christopheralanwest · 2019-06-12T21:22:17Z

+1

The sole purpose of this PR is to support PR #26892. Given the reco signature for that PR, I am signing off here.

cmsbuild · 2019-06-12T21:22:47Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

fabiocos · 2019-06-13T07:47:40Z

+1

Update GTs to include new EGamma regression

42bc42c

cmsbuild added this to the CMSSW_11_0_X milestone Jun 4, 2019

cmsbuild added alca-pending code-checks-pending comparison-pending orp-pending pending-signatures tests-pending labels Jun 4, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 4, 2019

cmsbuild mentioned this pull request Jun 4, 2019

Adapting EGRegression Modifiers to 106X and adding V3 modifier #26892

Merged

cmsbuild added requires-external tests-started and removed tests-pending labels Jun 4, 2019

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels Jun 4, 2019

cmsbuild added tests-started and removed tests-rejected labels Jun 4, 2019

cmsbuild added the tests-approved label Jun 10, 2019

cmsbuild added comparison-available and removed comparison-pending labels Jun 10, 2019

cmsbuild added tests-started and removed tests-approved labels Jun 10, 2019

cmsbuild added comparison-pending tests-approved and removed comparison-available tests-started labels Jun 10, 2019

cmsbuild added comparison-available and removed comparison-pending labels Jun 10, 2019

cmsbuild added alca-approved fully-signed and removed alca-pending pending-signatures labels Jun 12, 2019

cmsbuild added orp-approved and removed orp-pending labels Jun 13, 2019

cmsbuild merged commit 57db19f into cms-sw:master Jun 13, 2019

christopheralanwest mentioned this pull request Jun 13, 2019

Update global tags to include new EGamma regression [10_6_X] #27205

Merged

cmsbuild mentioned this pull request Jun 13, 2019

Avoid shared_ptr in RecoParticleFlow/PFProducer and remove PFSCEnergyCalibration #27154

Merged

christopheralanwest deleted the alca-new-gt-for-pr26892 branch August 21, 2019 14:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update global tags to include new EGamma regression #27089

Update global tags to include new EGamma regression #27089

christopheralanwest commented Jun 4, 2019

cmsbuild commented Jun 4, 2019

cmsbuild commented Jun 4, 2019

cmsbuild commented Jun 4, 2019

christopheralanwest commented Jun 4, 2019

cmsbuild commented Jun 4, 2019 •

edited

cmsbuild commented Jun 4, 2019

cmsbuild commented Jun 4, 2019

cmsbuild commented Jun 4, 2019 •

edited

cmsbuild commented Jun 4, 2019

cmsbuild commented Jun 4, 2019

cmsbuild commented Jun 10, 2019

Sam-Harper commented Jun 10, 2019 •

edited

cmsbuild commented Jun 10, 2019 •

edited

cmsbuild commented Jun 10, 2019

cmsbuild commented Jun 10, 2019

cmsbuild commented Jun 10, 2019

christopheralanwest commented Jun 12, 2019

cmsbuild commented Jun 12, 2019

fabiocos commented Jun 13, 2019

Update global tags to include new EGamma regression #27089

Update global tags to include new EGamma regression #27089

Conversation

christopheralanwest commented Jun 4, 2019

PR description:

PR validation:

if this PR is a backport please specify the original PR:

cmsbuild commented Jun 4, 2019

cmsbuild commented Jun 4, 2019

cmsbuild commented Jun 4, 2019

christopheralanwest commented Jun 4, 2019

cmsbuild commented Jun 4, 2019 • edited

cmsbuild commented Jun 4, 2019

cmsbuild commented Jun 4, 2019

cmsbuild commented Jun 4, 2019 • edited

cmsbuild commented Jun 4, 2019

cmsbuild commented Jun 4, 2019

cmsbuild commented Jun 10, 2019

Sam-Harper commented Jun 10, 2019 • edited

cmsbuild commented Jun 10, 2019 • edited

cmsbuild commented Jun 10, 2019

cmsbuild commented Jun 10, 2019

cmsbuild commented Jun 10, 2019

christopheralanwest commented Jun 12, 2019

cmsbuild commented Jun 12, 2019

fabiocos commented Jun 13, 2019

cmsbuild commented Jun 4, 2019 •

edited

cmsbuild commented Jun 4, 2019 •

edited

Sam-Harper commented Jun 10, 2019 •

edited

cmsbuild commented Jun 10, 2019 •

edited