Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running code-format for dqm-l1 #27104

Merged
merged 2 commits into from Jun 6, 2019
Merged

Running code-format for dqm-l1 #27104

merged 2 commits into from Jun 6, 2019

Conversation

cmsbuild
Copy link
Contributor

@cmsbuild cmsbuild commented Jun 5, 2019

Applying code-format for CMSSW category dqm,l1.
See the build logs here https://cmssdt.cern.ch/jenkins/job/GitHub-refactor-cmssw-module/361//console

cms-bot has successfully run the following:

  • scram build code-checks-all
  • scram build code-format-all
  • scram build

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Jun 5, 2019

please test

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Jun 5, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Jun 5, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27104/10213

  • This PR adds an extra 8KB to repository

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Jun 5, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/762/console Started: 2019/06/05 12:32

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Jun 5, 2019

A new Pull Request was created by @cmsbuild for master.

It involves the following packages:

DQMOffline/L1Trigger

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @rekovic, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@kreczko, @thomreis, @rociovilar this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Jun 5, 2019

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Jun 5, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Jun 5, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-836747/762/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3210222
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3209886
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@rekovic
Copy link
Contributor

rekovic commented Jun 6, 2019

+1

-technical

@jfernan2
Copy link
Contributor

jfernan2 commented Jun 6, 2019

+1

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Jun 6, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Jun 6, 2019

+1

@cmsbuild cmsbuild merged commit 4ee3906 into master Jun 6, 2019
@smuzaffar smuzaffar deleted the code-format-dqm-l1-9c6cd3 branch June 7, 2019 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants