Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Running code-format for analysis-reconstruction #27115

Merged
merged 3 commits into from Jun 12, 2019
Merged

Running code-format for analysis-reconstruction #27115

merged 3 commits into from Jun 12, 2019

Conversation

cmsbuild
Copy link
Contributor

@cmsbuild cmsbuild commented Jun 5, 2019

Applying code-format for CMSSW category analysis,reconstruction.
See the build logs here https://cmssdt.cern.ch/jenkins/job/GitHub-refactor-cmssw-module/365//console

cms-bot has successfully run the following:

  • scram build code-checks-all
  • scram build code-format-all
  • scram build

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Jun 5, 2019

please test

@cmsbuild cmsbuild added this to the CMSSW_11_0_X milestone Jun 5, 2019
@cmsbuild
Copy link
Contributor Author

cmsbuild commented Jun 5, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Jun 5, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27115/10225

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Jun 5, 2019 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/777/console Started: 2019/06/05 14:16

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Jun 5, 2019

A new Pull Request was created by @cmsbuild for master.

It involves the following packages:

CommonTools/CandAlgos
JetMETCorrections/Type1MET
PhysicsTools/PatUtils
PhysicsTools/SelectorUtils

@perrotta, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks.
@TaiSakuma, @gouskos, @rappoccio, @HeinerTholen, @ahinzmann, @peruzzim, @seemasharmafnal, @mmarionncern, @makortel, @smoortga, @acaudron, @jdolen, @drkovalskyi, @ferencek, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @clelange, @JyothsnaKomaragiri, @mverzett, @gpetruc, @mariadalfonso, @pvmulder this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Jun 5, 2019

-1

Tested at: 4bb99cd

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-97757d/777/summary.html

I found follow errors while testing this PR

Failed tests: Build ClangBuild

  • Build:

I found compilation warning when building: See details on the summary page.

  • Clang:

I found compilation warning while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

See details on the summary page.

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Jun 5, 2019

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

perrotta
perrotta reviewed Jun 7, 2019
View reviewed changes
PhysicsTools/SelectorUtils/interface/CutApplicatorBase.h Outdated

result_type operator()(const argument_type&) const override

result_type operator()(const argument_type&) const
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why override got lost?
Please fix

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy removed it.

/pool/condor/dir_9015/jenkins/workspace/GitHub-refactor-cmssw-module/CMSSW_11_0_X_2019-06-04-2300/src/PhysicsTools/SelectorUtils/interface/CutApplicatorBase.h:62:15: warning: 'override' is redundant since the function is already declared 'final' [modernize-use-override]
  result_type operator()(const argument_type&) const override
              ^                                      ~~~~~~~~
Suppressed 1984 warnings (1975 in non-user code, 8 NOLINT, 1 with check filters)

I will check why clang compiler did not see the final keyword

@smuzaffar
llvm warning fix while building rot dicts
82d8be6 
clang-tidy removes the `override` keyword as operator is already marked `final` but during ROOT dictionary build `final` is hidden due to 
`#if !defined(__CINT__) && !defined(__MAKECINT__) && !defined(__REFLEX__)` condition and generate warning. 

```
PhysicsTools/SelectorUtils/interface/CutApplicatorBase.h:62:15: warning: 'override' is redundant since the function is already declared 'final' [modernize-use-override]
  result_type operator()(const argument_type&) const override
              ^                                      ~~~~~~~~
Suppressed 1984 warnings (1975 in non-user code, 8 NOLINT, 1 with check filters)
```
@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor Author

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor Author

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27115/10309

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Jun 11, 2019 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/865/console Started: 2019/06/11 10:24

@cmsbuild
Copy link
Contributor Author

Pull request #27115 was updated. @perrotta, @cmsbuild, @santocch, @slava77 can you please check and sign again.

@cmsbuild
Copy link
Contributor Author

+1
Tested at: 82d8be6
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-97757d/865/summary.html

@cmsbuild
Copy link
Contributor Author

Comparison job queued.

@cmsbuild
Copy link
Contributor Author

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-97757d/865/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3215458
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3215123
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@perrotta
Copy link
Contributor

+1

  • Technical
  • Jenkins tests pass

@fabiocos
Copy link
Contributor

@santocch now the PR looks ok to me, please check, I will move forward with its integration

@santocch
Copy link

+1

@cmsbuild
Copy link
Contributor Author

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit ebc5ddc into master Jun 12, 2019
@smuzaffar smuzaffar deleted the code-format-analysis-reconstruction-9358e0 branch June 20, 2019 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perrotta perrotta perrotta left review comments

@smuzaffar smuzaffar smuzaffar left review comments

Assignees
No one assigned
Labels
analysis-approved code-checks-approved comparison-available fully-signed orp-approved reconstruction-approved tests-approved
Projects
None yet
Milestone
CMSSW_11_0_X
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@cmsbuild @smuzaffar @perrotta @fabiocos @santocch