New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Running code-format for simulation-upgrade #27137
Conversation
please test |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27137/10274
|
The tests are being triggered in jenkins. |
A new Pull Request was created by @cmsbuild for master. It involves the following packages: SimTracker/SiPhase2Digitizer @cmsbuild, @civanch, @kpedro88, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pixdet, | ||
bfield, | ||
ionization_points, | ||
collection_points); // transforms _ionization_points to collection_points |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to be fixed
|
||
// compute induced signal on readout elements and add to _signal | ||
induce_signal(*it, simHitGlobalIndex, tofBin, pixdet, collection_points); // *ihit needed only for SimHit<-->Digi link | ||
induce_signal( | ||
*it, simHitGlobalIndex, tofBin, pixdet, collection_points); // *ihit needed only for SimHit<-->Digi link |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to be fixed
pixdet, | ||
bfield, | ||
ionization_points, | ||
collection_points); // transforms _ionization_points to collection_points |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to be fixed
|
||
// compute induced signal on readout elements and add to _signal | ||
induce_signal(*it, simHitGlobalIndex, tofBin, pixdet, collection_points); // *ihit needed only for SimHit<-->Digi link | ||
induce_signal( | ||
*it, simHitGlobalIndex, tofBin, pixdet, collection_points); // *ihit needed only for SimHit<-->Digi link |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to be fixed
|
||
DeadModules(use_deadmodule_DB_ | ||
? Parameters() | ||
: conf_specific.getParameter<Parameters>("DeadModules")), // get dead module from cfg file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to be fixed
const DetId& detId) const; | ||
|
||
virtual void module_killing_conf( | ||
uint32_t detID); // remove dead modules using the list in the configuration file PixelDigi_cfi.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to be fixed
pixdet, | ||
bfield, | ||
ionization_points, | ||
collection_points); // transforms _ionization_points to collection_points |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to be fixed
// compute induced signal on readout elements and add to _signal | ||
induce_signal(*it, simHitGlobalIndex, tofBin, pixdet, collection_points); // *ihit needed only for SimHit<-->Digi link | ||
induce_signal( | ||
*it, simHitGlobalIndex, tofBin, pixdet, collection_points); // *ihit needed only for SimHit<-->Digi link |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to be fixed
pixdet, | ||
bfield, | ||
ionization_points, | ||
collection_points); // transforms _ionization_points to collection_points |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to be fixed
|
||
// compute induced signal on readout elements and add to _signal | ||
|
||
induce_signal(*it, simHitGlobalIndex, tofBin, pixdet, collection_points); // *ihit needed only for SimHit<-->Digi link | ||
induce_signal( | ||
*it, simHitGlobalIndex, tofBin, pixdet, collection_points); // *ihit needed only for SimHit<-->Digi link |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to be fixed
@fabiocos , I have no problem with whatever code format is doing but this is a frequently used practice, when a comment is in the end of a line. In a small window such comment make a mess and hardly readable, I personally use to put a comment in the previous line. We may left this for developer allowing both ways of doing. Alternativly, can code format script do this automatically? |
+1 |
+upgrade |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
@civanch there is obviously nothing wrong in having a comment at the end of the line, but if it is too long clang-format splits the line. In several other PRs we have preferred to restore a one line instruction by moving the comment to the line before. I have taken care of several other PRs in this sense, and I may do it also for this one. I am not sure about what is your alternative proposal... |
+1 |
Applying code-format for CMSSW category simulation,upgrade.
See the build logs here https://cmssdt.cern.ch/jenkins/job/GitHub-refactor-cmssw-module/380//console
cms-bot has successfully run the following: