Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ecal DPG - Deploy new software (based on BDT) to recover isolated dead channels… #27175

Merged
merged 6 commits into from Aug 2, 2019

Conversation

nancymarinelli
Copy link
Contributor

… in the Ecal barrel
@taroni

PR description:

A new algorithm, based on BDT energy regression is implemented for recovering isolated dead channels in the ECAL barrel

PR validation:

The functionality of the PR has been tested in the 11_0_x IB 06-09-2300. The physics validation has been widely done in 10_2_x and presented in many meetings

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27175/10329

  • This PR adds an extra 28KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @nancymarinelli for master.

It involves the following packages:

RecoLocalCalo/EcalDeadChannelRecoveryAlgos
RecoLocalCalo/EcalRecProducers

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@argiro this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@nancymarinelli
Copy link
Contributor Author

A new Pull Request was created by @nancymarinelli for master.

It involves the following packages:

RecoLocalCalo/EcalDeadChannelRecoveryAlgos
RecoLocalCalo/EcalRecProducers

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@argiro this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@taroni

singleChannelRecoveryThreshold = cms.double(0.70),##default 8
sum8ChannelRecoveryThreshold = cms.double(0.),##default 8
bdtWeightFileNoCracks = cms.FileInPath("RecoLocalCalo/EcalDeadChannelRecoveryAlgos/data/TMVARegression_trainingWithAliveCrystalsAllRH_8GT700MeV_RelEne_noCracks_rightTAG_data_BDTG.weights.xml"),
bdtWeightFileCracks = cms.FileInPath("RecoLocalCalo/EcalDeadChannelRecoveryAlgos/data/TMVARegression_trainingWithAliveCrystalsAllRH_8GT700MeV_RelEne_onlyCracks_rightTAG_data_BDTG.weights.xml"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC, these files are not available yet in a cms-data repo pull request.
Please also check if the name can be shortened.
It looks like noCracks.xml and onlyCracks.xml perhaps with some "v1" for future version tracking is enough.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27175/10335

  • This PR adds an extra 32KB to repository

@cmsbuild
Copy link
Contributor

Pull request #27175 was updated. @perrotta, @cmsbuild, @slava77 can you please check and sign again.

@mrodozov
Copy link
Contributor

when your PR is ready to be tested along with it's related cms-data PR
use the following without the quotes
please test with https://github.com/cms-data/RecoLocalCalo-EcalDeadChannelRecoveryAlgos/pull/1, https://github.com/cms-sw/cmsdist/pull/5037
We'll try to remove the cmsdist PR tag gimmick soon (but we're not there yet)
Since the new data PR only adds new files we might merge it and if we do I'll update my comment here

@nancymarinelli
Copy link
Contributor Author

@slava77
Copy link
Contributor

slava77 commented Jun 12, 2019

@cmsbuild please test with cms-data/RecoLocalCalo-EcalDeadChannelRecoveryAlgos#1

@mrodozov we were able to test with just cms-data in some recent PRs. Is the cmsdist required again?

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 12, 2019

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-data/RecoLocalCalo-EcalDeadChannelRecoveryAlgos#1
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/915/console Started: 2019/06/12 16:56

@cmsbuild
Copy link
Contributor

ERROR: There was an issue generating parameters for
cmsBuild '--source' flag for spec file data-RecoLocalCalo-EcalDeadChannelRecoveryAlgos from cms-data/RecoLocalCalo-EcalDeadChannelRecoveryAlgos repo.

@cmsbuild
Copy link
Contributor

Pull request #27175 was updated. @perrotta, @cmsbuild, @slava77 can you please check and sign again.

@slava77
Copy link
Contributor

slava77 commented Jul 31, 2019

please test with cms-data/RecoLocalCalo-EcalDeadChannelRecoveryAlgos#1

@nancymarinelli thank you for the quick follow up to the review comments.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 31, 2019

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-data/RecoLocalCalo-EcalDeadChannelRecoveryAlgos#1
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1746/console Started: 2019/07/31 17:09

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9d7fd8/1746/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-9d7fd8/22034.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2026D46_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D46+RecoFullGlobal_2026D46+HARVESTFullGlobal_2026D46

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 2484130
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2483812
  • DQMHistoTests: Total skipped: 317
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 132 log files, 14 edm output root files, 32 DQM output files

@slava77
Copy link
Contributor

slava77 commented Aug 1, 2019

+1

for #27175 edab6bc

  • code changes are in line with the PR description and the follow up review
  • jenkins tests pass and comparisons with the baseline show no differences
    • the default behavior is no change
    • the case of running with the recovery method enabled was tested earlier with 58ca071 and appears to be OK based on the jenkins comparisons

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 1, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@kpedro88
Copy link
Contributor

kpedro88 commented Aug 2, 2019

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet