Remove redundant unique_ptr constructor calls from Reco #27194

makortel · 2019-06-12T19:27:19Z

PR description:

This PR is a follow-up to #27097 to remove now-redundant calls to unique_ptr constructor.

PR validation:

Code compiles

cmsbuild · 2019-06-12T19:27:54Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-06-12T19:34:04Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27194/10359

This PR adds an extra 188KB to repository

cmsbuild · 2019-06-12T19:34:38Z

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

RecoEcal/EgammaClusterProducers
RecoEcal/EgammaCoreTools
RecoEgamma/EgammaElectronAlgos
RecoEgamma/EgammaElectronProducers
RecoEgamma/EgammaHLTProducers
RecoEgamma/EgammaPhotonAlgos
RecoHGCal/TICL
RecoHI/HiEgammaAlgos
RecoLocalCalo/EcalRecProducers
RecoLocalCalo/HGCalRecProducers
RecoLocalFastTime/FTLRecProducers
RecoLocalMuon/GEMSegment
RecoMuon/MuonIdentification
RecoMuon/MuonIsolation
RecoMuon/MuonIsolationProducers
RecoMuon/TrackerSeedGenerator
RecoParticleFlow/PFClusterProducer
RecoParticleFlow/PFProducer
RecoPixelVertexing/PixelTriplets
RecoTauTag/RecoTau
RecoTracker/CkfPattern
RecoTracker/ConversionSeedGenerators
RecoTracker/TkSeedGenerator
TrackingTools/TrajectoryFiltering

@perrotta, @cmsbuild, @slava77, @kpedro88, @Martin-Grunewald, @fwyzard can you please review it and eventually sign? Thanks.
@felicepantaleo, @jainshilpi, @abbiendi, @kpedro88, @argiro, @jshlee, @pfs, @varuns23, @seemasharmafnal, @mmarionncern, @sethzenz, @battibass, @jhgoh, @lgray, @HuguesBrun, @drkovalskyi, @trocino, @rociovilar, @vandreev11, @Sam-Harper, @kurtejung, @GiacomoSguazzoni, @rovere, @VinInn, @cseez, @bellan, @hatakeyamak, @mschrode, @ebrondol, @dgulhan, @echapon, @mandrenguyen, @jazzitup, @edjtscott, @calderona, @yenjie, @bachtis, @cbernet, @gpetruc, @yetkinyilmaz, @folguera this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

makortel · 2019-06-12T19:37:23Z

@cmsbuild, please test

cmsbuild · 2019-06-12T19:37:58Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/925/console Started: 2019/06/12 21:38

cmsbuild · 2019-06-12T22:27:20Z

+1
Tested at: f5d7066
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-815dbe/925/summary.html

cmsbuild · 2019-06-12T22:27:23Z

Comparison job queued.

cmsbuild · 2019-06-13T00:44:02Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-815dbe/925/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 33
DQMHistoTests: Total histograms compared: 3254096
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3253761
DQMHistoTests: Total skipped: 334
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
Checked 137 log files, 14 edm output root files, 33 DQM output files

kpedro88 · 2019-06-13T21:57:15Z

+upgrade

perrotta · 2019-06-14T09:20:29Z

+1

Technical
Jenkins tests pass

cmsbuild · 2019-06-24T19:25:04Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-815dbe/1133/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 33
DQMHistoTests: Total histograms compared: 3254598
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3254263
DQMHistoTests: Total skipped: 334
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
Checked 137 log files, 14 edm output root files, 33 DQM output files

slava77 · 2019-06-25T15:28:10Z

hold

until the situation with #27160 is clear (hopefully that one can go in first)

cmsbuild · 2019-06-25T15:28:41Z

Pull request has been put on hold by @slava77
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

slava77 · 2019-06-27T07:16:15Z

unhold

perrotta · 2019-06-27T07:19:55Z

RecoEgamma/EgammaElectronProducers/plugins/GEDGsfElectronFinalizer.cc

+        // it means that there is a PFCandidate with the same GsfTrack
+        myMvaOutput.status = 3;  //as defined in PFCandidateEGammaExtra.h
+        newElectron.setPassPflowPreselection(
+            true);  //this is currently fully redundant with mvaOutput.stats so candidate for removal


Line break issue (it can be solved in a follow-up patch, as usual)

@fabiocos I can take care of these after this PR has been merged.

perrotta · 2019-06-27T07:20:02Z

RecoEgamma/EgammaElectronProducers/plugins/GEDGsfElectronFinalizer.cc

+      } else {
+        myMvaOutput.status = 4;  //
+        newElectron.setPassPflowPreselection(
+            false);  //this is currently fully redundant with mvaOutput.stats so candidate for removal


Line break issue (it can be solved in a follow-up patch, as usual)

perrotta · 2019-06-27T07:28:10Z

+1

Only rebased and clang-formatted after last reco signature in Remove redundant unique_ptr constructor calls from Reco #27194 (comment)
- Only a couple of comments about that formatting added in Remove redundant unique_ptr constructor calls from Reco #27194 (review), that do not have to be necessarily dealt with already in this PR

Martin-Grunewald · 2019-06-27T07:36:23Z

+1

kpedro88 · 2019-06-27T07:44:37Z

+upgrade

cmsbuild · 2019-06-27T07:45:11Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

fabiocos · 2019-06-27T20:16:43Z

+1

cmsbuild added this to the CMSSW_11_0_X milestone Jun 12, 2019

cmsbuild added code-checks-pending comparison-pending hlt-pending orp-pending pending-signatures reconstruction-pending tests-pending upgrade-pending labels Jun 12, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 12, 2019

cmsbuild added tests-started and removed tests-pending labels Jun 12, 2019

cmsbuild added tests-approved and removed tests-started labels Jun 12, 2019

cmsbuild added comparison-available and removed comparison-pending labels Jun 13, 2019

cmsbuild added upgrade-approved and removed upgrade-pending labels Jun 13, 2019

cmsbuild removed the reconstruction-pending label Jun 14, 2019

cmsbuild added the tests-approved label Jun 24, 2019

cmsbuild added comparison-available and removed comparison-pending labels Jun 24, 2019

cmsbuild mentioned this pull request Jun 25, 2019

TICL Reorganization, reloaded. #27160

Merged

cmsbuild added the hold label Jun 25, 2019

perrotta mentioned this pull request Jun 27, 2019

Running code-format for reconstruction-upgrade #27348

Merged

cmsbuild removed the hold label Jun 27, 2019

perrotta reviewed Jun 27, 2019

View reviewed changes

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Jun 27, 2019

cmsbuild added hlt-approved and removed hlt-pending labels Jun 27, 2019

cmsbuild added fully-signed upgrade-approved and removed pending-signatures upgrade-pending labels Jun 27, 2019

cmsbuild mentioned this pull request Jun 27, 2019

Ecal DPG - Deploy new software (based on BDT) to recover isolated dead channels… #27175

Merged

cmsbuild added orp-approved and removed orp-pending labels Jun 27, 2019

cmsbuild merged commit ae7fd19 into cms-sw:master Jun 27, 2019

makortel mentioned this pull request Jun 28, 2019

Fine-tune code formatting in GEDGsfElectronFinalizer.cc #27403

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove redundant unique_ptr constructor calls from Reco #27194

Remove redundant unique_ptr constructor calls from Reco #27194

makortel commented Jun 12, 2019

cmsbuild commented Jun 12, 2019

cmsbuild commented Jun 12, 2019

cmsbuild commented Jun 12, 2019

makortel commented Jun 12, 2019

cmsbuild commented Jun 12, 2019 •

edited

cmsbuild commented Jun 12, 2019

cmsbuild commented Jun 12, 2019

cmsbuild commented Jun 13, 2019

kpedro88 commented Jun 13, 2019

perrotta commented Jun 14, 2019

cmsbuild commented Jun 24, 2019

slava77 commented Jun 25, 2019

cmsbuild commented Jun 25, 2019

slava77 commented Jun 27, 2019

perrotta Jun 27, 2019

makortel Jun 27, 2019

perrotta Jun 27, 2019

perrotta commented Jun 27, 2019

Martin-Grunewald commented Jun 27, 2019

kpedro88 commented Jun 27, 2019

cmsbuild commented Jun 27, 2019

fabiocos commented Jun 27, 2019

Remove redundant unique_ptr constructor calls from Reco #27194

Remove redundant unique_ptr constructor calls from Reco #27194

Conversation

makortel commented Jun 12, 2019

PR description:

PR validation:

cmsbuild commented Jun 12, 2019

cmsbuild commented Jun 12, 2019

cmsbuild commented Jun 12, 2019

makortel commented Jun 12, 2019

cmsbuild commented Jun 12, 2019 • edited

cmsbuild commented Jun 12, 2019

cmsbuild commented Jun 12, 2019

cmsbuild commented Jun 13, 2019

kpedro88 commented Jun 13, 2019

perrotta commented Jun 14, 2019

cmsbuild commented Jun 24, 2019

slava77 commented Jun 25, 2019

cmsbuild commented Jun 25, 2019

slava77 commented Jun 27, 2019

perrotta Jun 27, 2019

Choose a reason for hiding this comment

makortel Jun 27, 2019

Choose a reason for hiding this comment

perrotta Jun 27, 2019

Choose a reason for hiding this comment

perrotta commented Jun 27, 2019

Martin-Grunewald commented Jun 27, 2019

kpedro88 commented Jun 27, 2019

cmsbuild commented Jun 27, 2019

fabiocos commented Jun 27, 2019

cmsbuild commented Jun 12, 2019 •

edited