Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running code-format for l1 #27266

Merged
merged 1 commit into from Jun 20, 2019
Merged

Running code-format for l1 #27266

merged 1 commit into from Jun 20, 2019

Conversation

cmsbuild
Copy link
Contributor

Applying code-format for CMSSW category l1.
See the build logs here https://cmssdt.cern.ch/jenkins/job/GitHub-refactor-cmssw-module/411//console

cms-bot has successfully run the following:

  • scram build code-checks-all
  • scram build code-format-all
  • scram build

@cmsbuild
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor Author

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor Author

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27266/10467

  • This PR adds an extra 8KB to repository

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Jun 19, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1039/console Started: 2019/06/19 14:11

@cmsbuild
Copy link
Contributor Author

A new Pull Request was created by @cmsbuild for master.

It involves the following packages:

DataFormats/L1DTTrackFinder
L1TriggerConfig/DTTPGConfigProducers

@cmsbuild, @rekovic, @benkrikler can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @rovere this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Jun 19, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1060/console Started: 2019/06/19 17:03

@cmsbuild
Copy link
Contributor Author

@cmsbuild
Copy link
Contributor Author

Comparison job queued.

@cmsbuild
Copy link
Contributor Author

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-000d93/1039/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3254096
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3253760
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@cmsbuild
Copy link
Contributor Author

@cmsbuild
Copy link
Contributor Author

Comparison job queued.

@cmsbuild
Copy link
Contributor Author

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-000d93/1060/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3254096
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3253761
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@fabiocos
Copy link
Contributor

+1

@fabiocos
Copy link
Contributor

merge

@rekovic this PR looks ok to me, please have a look in case

@cmsbuild cmsbuild merged commit 36d4ca3 into master Jun 20, 2019
@smuzaffar smuzaffar deleted the code-format-l1-61ed9a branch June 20, 2019 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants